Skip to content

Commit 8b989bf

Browse files
benfrybenfry
committed
writing release notes, switch to BUFFER_READING instead of DEPTH_READING
1 parent f0f7e24 commit 8b989bf

6 files changed

Lines changed: 174 additions & 14 deletions

File tree

‎build/shared/revisions.txt‎

Lines changed: 161 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,171 @@ mean we've worked out all the bugs just yet, but hey, who has?
88
A still-in-progress rundown of the changes in Processing 3 is here:
99
https://github.com/processing/processing/wiki/Changes-in-3.0
1010

11+
2.x Modes, Tools, and Libraries will need to be updated for 3.x, so if you're
12+
an author of these, see the notes in the link above. We're also planning some
13+
sort of online Q & A / office hours / talk to Ben about what's changed session
14+
to help folks along. We want to help, we just need to find the time.
15+
1116
For those into the nitty gritty, here are the details of what's changed
1217
since 3.0 alpha 11:
1318

1419

20+
[ bug fixes ]
21+
22+
+ The new Welcome screen! was... completely broken
23+
https://github.com/processing/processing/issues/3474
24+
25+
+ StringIndexOutOfBoundsException while preprocessing
26+
https://github.com/processing/processing/issues/3531
27+
28+
+ Run/Stop/Debug buttons do not fire if the mouse moves during the click
29+
https://github.com/processing/processing/issues/3529
30+
31+
+ Some contributions were listed multiple times
32+
https://github.com/processing/processing/issues/3353
33+
34+
+ Do not filter Ctrl+Alt+? out as menu mnemonics
35+
https://github.com/processing/processing/issues/3536
36+
https://github.com/processing/processing/pull/3537
37+
38+
+ Fix delete tab shortcut in toolbar popup
39+
https://github.com/processing/processing/pull/3535
40+
41+
+ Deleted tab still present in tab menu
42+
https://github.com/processing/processing/issues/3534
43+
https://github.com/processing/processing/pull/3542
44+
https://github.com/processing/processing/pull/3541
45+
46+
+ Make PFont.size protected again
47+
https://github.com/processing/processing/issues/3519
48+
49+
+ Tweak implementation of PVector.heading()
50+
https://github.com/processing/processing/issues/3511
51+
52+
+ Fix problem with JAR loading inside createInputRaw()
53+
https://github.com/processing/processing/pull/3514
54+
55+
56+
[ changes, because not everything is a bug ]
57+
58+
+ Add new console/errors icons to the tabs in the footer
59+
60+
+ Get images working in the Welcome screen
61+
https://github.com/processing/processing/issues/3494
62+
63+
+ Add getSurface() method ('surface' is protected in PApplet)
64+
65+
+ Remove 'contrib updates available' dialog box for now. A new version
66+
is coming soon that will be better-integrated with the editor.
67+
68+
69+
[ internal changes you'll probably never notice ]
70+
71+
+ Add message that says it's safe to ignore the tools.jar warning
72+
73+
+ Add "git pull" on processing-docs for "dist" target
74+
75+
+ Update to launch4j 3.8
76+
77+
78+
[ contributions by our fine community ]
79+
80+
+ Fix contribution compatibility check
81+
https://github.com/processing/processing/pull/3479
82+
83+
+ Update Spanish translation
84+
https://github.com/processing/processing/pull/3480
85+
86+
+ Fix bug with tab sorting when adding new tabs
87+
https://github.com/processing/processing/pull/3540
88+
https://github.com/processing/processing/issues/3099
89+
90+
91+
[ this summer, Google's paying folks to stay indoors & work on Processing ]
92+
93+
+ CM updates dialog box doesn't open CM
94+
https://github.com/processing/processing/issues/3481
95+
https://github.com/processing/processing/pull/3489
96+
97+
+ Adding CM ellipses only when text is long
98+
https://github.com/processing/processing/pull/3470
99+
100+
+ Include mode imports when rewriting .properties file
101+
https://github.com/processing/processing/pull/3499
102+
https://github.com/processing/processing/issues/3492
103+
104+
+ Assortment of patches from gohai's arm-3.0 branch
105+
https://github.com/processing/processing/pull/3522
106+
107+
108+
[ Jakub joins Andres in a battle of wits and test of wills against OpenGL ]
109+
110+
+ Implement depth sorting! Use hint(ENABLE_DEPTH_SORT) and say goobye
111+
to your 3D transparency woes!
112+
https://github.com/processing/processing/issues/90
113+
https://github.com/processing/processing/issues/2235
114+
https://github.com/processing/processing/pull/3507
115+
https://github.com/processing/processing/pull/3477
116+
https://github.com/processing/processing/pull/3410
117+
https://github.com/processing/processing/pull/3372
118+
119+
+ Remove size() from setup() when copying to settings()
120+
https://github.com/processing/processing/pull/3517
121+
122+
+ Remove mode parameters from createShape(), fixes parameter collision issues
123+
https://github.com/processing/processing/pull/3516
124+
125+
+ Radius for rect not working on PShape
126+
https://github.com/processing/processing/issues/2646
127+
128+
+ Bug in arc with createShape()
129+
https://github.com/processing/processing/issues/3018
130+
131+
+ OpenGL sketch flickers when draw() is missing or empty
132+
https://github.com/processing/processing/issues/3473
133+
https://github.com/processing/processing/pull/3521
134+
135+
+ size() errors
136+
https://github.com/processing/processing/issues/3483
137+
138+
+ rect() with stroke outline renders 1px wider and taller in P2D
139+
behavior is correct, explanation provided
140+
https://github.com/processing/processing/issues/2065
141+
https://github.com/processing/processing/issues/2065
142+
143+
+ setVertex() not working in P3D and P2D
144+
https://github.com/processing/processing/issues/3022
145+
https://github.com/processing/processing/pull/3528
146+
147+
+ Add hint(ENABLE_BUFFER_READING) to handle stencil/depth buffers
148+
https://github.com/processing/processing/pull/3527
149+
https://github.com/processing/processing/issues/2771
150+
151+
X ArrayIndexOutOfBoundsException error when enabling depth sorting in P3D
152+
X https://github.com/processing/processing/pull/3477
153+
X https://github.com/processing/processing/issues/3476
154+
X Fix curves - properly this time
155+
X https://github.com/processing/processing/pull/3501
156+
X Remove duplicate curve vertex
157+
X https://github.com/processing/processing/pull/3496
158+
X https://github.com/processing/processing/issues/2937
159+
X JOGL window size is now set properly
160+
X https://github.com/processing/processing/pull/3493
161+
X https://github.com/processing/processing/issues/3223
162+
X more sorter work
163+
X https://github.com/processing/processing/pull/3507
164+
X Depth sorting wrong when drawing inside setup(), P3D
165+
X can no longer be reproduced
166+
X https://github.com/processing/processing/issues/2483
167+
X Device parsing on Linux is incorrect
168+
X https://github.com/processing/processing/issues/3532
169+
o don't show display warning when display 1 doesn't exist
170+
X apparently this was an OpenGL bug (#3532)
171+
X flush geometry when lighting changes
172+
X otherwise lights apply to the entire scene
173+
X https://github.com/processing/processing/issues/3533
174+
175+
15176

16177
. . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
17178

‎core/src/processing/core/PConstants.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -514,8 +514,8 @@ public interface PConstants {
514514
static final int ENABLE_STROKE_PURE = 9;
515515
static final int DISABLE_STROKE_PURE = -9;
516516

517-
static final int ENABLE_DEPTH_READING = 10;
518-
static final int DISABLE_DEPTH_READING = -10;
517+
static final int ENABLE_BUFFER_READING = 10;
518+
static final int DISABLE_BUFFER_READING = -10;
519519

520520
static final int HINT_COUNT = 11;
521521
}

‎core/src/processing/opengl/PGL.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -550,7 +550,7 @@ protected void syncBackTexture() {
550550
bindFramebufferImpl(READ_FRAMEBUFFER, glMultiFbo.get(0));
551551
bindFramebufferImpl(DRAW_FRAMEBUFFER, glColorFbo.get(0));
552552
int mask = COLOR_BUFFER_BIT;
553-
if (pg.getHint(PConstants.ENABLE_DEPTH_READING)) {
553+
if (pg.getHint(PConstants.ENABLE_BUFFER_READING)) {
554554
mask |= DEPTH_BUFFER_BIT | STENCIL_BUFFER_BIT;
555555
}
556556
blitFramebuffer(0, 0, fboWidth, fboHeight,
@@ -795,7 +795,7 @@ private void createFBOLayer() {
795795
framebufferTexture2D(FRAMEBUFFER, COLOR_ATTACHMENT0, TEXTURE_2D,
796796
glColorTex.get(backTex), 0);
797797

798-
if (!multisample || pg.getHint(PConstants.ENABLE_DEPTH_READING)) {
798+
if (!multisample || pg.getHint(PConstants.ENABLE_BUFFER_READING)) {
799799
// If not multisampled, this is the only depth and stencil buffer.
800800
// If multisampled and depth reading enabled, these are going to
801801
// hold downsampled depth and stencil buffers.
@@ -2717,7 +2717,7 @@ protected interface FontOutline {
27172717

27182718
public void readPixels(int x, int y, int width, int height, int format, int type, Buffer buffer){
27192719
boolean multisampled = isMultisampled() || pg.offscreenMultisample;
2720-
boolean depthReadingEnabled = pg.getHint(PConstants.ENABLE_DEPTH_READING);
2720+
boolean depthReadingEnabled = pg.getHint(PConstants.ENABLE_BUFFER_READING);
27212721
boolean depthRequested = format == STENCIL_INDEX || format == DEPTH_COMPONENT || format == DEPTH_STENCIL;
27222722

27232723
if (multisampled && depthRequested && !depthReadingEnabled) {

‎core/src/processing/opengl/PGraphicsOpenGL.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2236,7 +2236,7 @@ protected void beginPixelsOp(int op) {
22362236
if (offscreenMultisample) {
22372237
// Making sure the offscreen FBO is up-to-date
22382238
int mask = PGL.COLOR_BUFFER_BIT;
2239-
if (hints[ENABLE_DEPTH_READING]) {
2239+
if (hints[ENABLE_BUFFER_READING]) {
22402240
mask |= PGL.DEPTH_BUFFER_BIT | PGL.STENCIL_BUFFER_BIT;
22412241
}
22422242
multisampleFramebuffer.copy(offscreenFramebuffer, mask);
@@ -2479,9 +2479,9 @@ public void hint(int which) {
24792479
flush();
24802480
isDepthSortingEnabled = false;
24812481
}
2482-
} else if (which == ENABLE_DEPTH_READING) {
2482+
} else if (which == ENABLE_BUFFER_READING) {
24832483
restartPGL();
2484-
} else if (which == DISABLE_DEPTH_READING) {
2484+
} else if (which == DISABLE_BUFFER_READING) {
24852485
restartPGL();
24862486
}
24872487
}
@@ -6908,7 +6908,7 @@ protected void initOffscreen() {
69086908
// The offscreen framebuffer where the multisampled image is finally drawn
69096909
// to. If depth reading is disabled it doesn't need depth and stencil buffers
69106910
// since they are part of the multisampled framebuffer.
6911-
if (hints[ENABLE_DEPTH_READING]) {
6911+
if (hints[ENABLE_BUFFER_READING]) {
69126912
offscreenFramebuffer =
69136913
new FrameBuffer(this, texture.glWidth, texture.glHeight, 1, 1,
69146914
depthBits, stencilBits, packed, false);

‎core/todo.txt‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ X https://github.com/processing/processing/pull/3372
4747
o rect() with stroke outline renders 1px wider and taller in P2D
4848
X behavior is correct, explanation provided
4949
X https://github.com/processing/processing/issues/2065
50+
X sort out edge + 1 issue on stroke/fill for rectangles
51+
X http://code.google.com/p/processing/issues/detail?id=509
5052
X setVertex() not working in P3D and P2D
5153
X https://github.com/processing/processing/issues/3022
5254
X https://github.com/processing/processing/pull/3528
@@ -85,6 +87,7 @@ _ update wiki/docs to say "don't override sketchXxxx() methods"
8587

8688

8789
3.0 final
90+
_ move blending calculations from PImage into PGraphics
8891
_ move AWT image loading into PImageAWT
8992
_ look into how GL and FX will handle from there
9093
_ run only the necessary pieces on the EDT
@@ -310,8 +313,6 @@ _ decision: add error messages where possible
310313
_ idea: set frameCount to -1 when setup not run yet?
311314
_ then set frameCount to 0 when setup() starts?
312315
_ need to clean up the hints in the reference/source
313-
_ sort out edge + 1 issue on stroke/fill for rectangles
314-
_ http://code.google.com/p/processing/issues/detail?id=509
315316
_ exactly how should pixel filling work with single pixel strokes?
316317
_ http://dev.processing.org/bugs/show_bug.cgi?id=1025 (no gcode)
317318
_ y2 position of rectangles not same as y2 position of lines

‎todo.txt‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ X update to launch4j 3.8
1919
X inquire about updated document icon
2020
X fix frame title for web frame (welcome window title disappeared)
2121
X fix the red for the console/error stuff and the status bar
22+
X write notes about changes with Toolkit and Util, and packages
2223

2324
fixed earlier
2425
X font fixes for Georgia in the examples
@@ -58,9 +59,6 @@ X https://github.com/processing/processing/pull/3522
5859
X Adding ellipses only when text is long
5960
X https://github.com/processing/processing/pull/3470
6061

61-
beta
62-
_ write notes about changes with Toolkit and Util, and packages
63-
6462

6563
3.0 final
6664
_ launch4j doesn't work from folders with non-native charsets

0 commit comments

Comments
 (0)