deal with url rollover bugs in the status bar (fixes #4695)

benfry · benfry · commit 286ebb500249 · 2016-10-29T09:38:44.000-04:00
diff --git a/app/src/processing/app/ui/EditorStatus.java b/app/src/processing/app/ui/EditorStatus.java
@@ -78,7 +78,7 @@ public class EditorStatus extends BasicSplitPaneDivider {  //JPanel {
   String url;
   int rightEdge;
   int mouseX;
-  boolean inside;
+  boolean urlRollover;
 
   Font font;
   FontMetrics metrics;
@@ -108,7 +108,7 @@ public void mouseEntered(MouseEvent e) {
 
       @Override
       public void mousePressed(MouseEvent e) {
-        if (inside) {
+        if (urlRollover) {
           Platform.openURL(url);
         }
       }
@@ -132,7 +132,7 @@ public void mouseMoved(MouseEvent e) {
 
 
   void updateMouse() {
-    if (inside) {
+    if (urlRollover) {
       setCursor(Cursor.getPredefinedCursor(Cursor.HAND_CURSOR));
     } else {
       setCursor(Cursor.getPredefinedCursor(Cursor.MOVE_CURSOR));
@@ -292,13 +292,19 @@ public void paint(Graphics screen) {
     g.setColor(fgColor[mode]);
     // https://github.com/processing/processing/issues/3265
     if (message != null) {
-      g.setFont(font); // needs to be set each time on osx
-      inside = (mouseX > LEFT_MARGIN && mouseX < rightEdge);
-      if (inside) {
+      // needs to be set each time on osx
+      g.setFont(font);
+      // calculate right edge of the text for rollovers (otherwise the pane
+      // cannot be resized up or down whenever a URL is being displayed)
+      rightEdge = LEFT_MARGIN + g.getFontMetrics().stringWidth(message);
+      // set the highlight color on rollover so that the user's not surprised
+      // to see the web browser open when they click
+      urlRollover = (url != null) &&
+        (mouseX > LEFT_MARGIN && mouseX < rightEdge);
+      if (urlRollover) {
         g.setColor(urlColor);
       }
       g.drawString(message, LEFT_MARGIN, (sizeH + ascent) / 2);
-      rightEdge = LEFT_MARGIN + g.getFontMetrics().stringWidth(message);
     }
 
     if (indeterminate) {
diff --git a/todo.txt b/todo.txt
@@ -14,8 +14,8 @@ X   https://github.com/processing/processing/commit/8a3a183f327a5ee680e1932dd9f1
 X more font tweaks to make mono fonts work properly after #4639
 _   update the Linux notes based on where we land on this
 _   https://github.com/processing/processing/wiki/Supported-Platforms#linux
-_ "Could not open the url" when clicking on the error message
-_   https://github.com/processing/processing/issues/4695
+X "Could not open the url" when clicking on the error message
+X   https://github.com/processing/processing/issues/4695
 _ launch4j bug with minimum JRE version (set to 102 for folks who have 101?)
 _   https://github.com/processing/processing/issues/4682
 _ sharing usage metrics about libraries
