What happens if i receive multiple webhook events simultaneously? #1743
Replies: 2 comments 5 replies
-
|
Hi @hahnbeelee, In my understanding, this could be related to GitHub's API or the server in charge of receiving these events. A good way to see if GitHub Events are triggered at the time you expect is to see your GitHub App's Event activity in
If the timing when the events are triggered looks correct to you we can check the server side. I would be happy to help here. |
Beta Was this translation helpful? Give feedback.
-
|
Both events are received and for a while they both run simultaneously (since they are both quite long requests) And then the first one just stops abruptly. I was curious if there is any internal logic within probot that limits multiple threads from running simultaneously? |
Beta Was this translation helpful? Give feedback.
-
|
As far as I know, Probot uses
There is the possibility some exception is thrown during the execution of one of your event handlers. Are you registering an module.exports = (app) => {
app.on("issues.opened", async (context) => {
...
});
app.onAny(async (context) => {
...
});
app.onError(async (error) => {
app.log.error(error);
});
}; |
Beta Was this translation helpful? Give feedback.
-
|
After 9s, |
Beta Was this translation helpful? Give feedback.
-
It's fun because I don't remember this piece of code and I was part of the contribution 🤣 |
Beta Was this translation helpful? Give feedback.
-
|
We are interested in the answer to this question. Our specific question is: if my webhook handler is sitting in an I think that the answer depends upon the deployment:
|
Beta Was this translation helpful? Give feedback.
-
Yes. Each incoming request is its own await.
Note that GitHub's timeout is 10 seconds. Probot will respond with a 202 after 9 seconds I think to communicate that the request was received but is still processing. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I'm creating a GitHub bot that creates a check run on every commit. It takes about 2 minutes to complete and when another commit is pushed, I noticed that sometimes the previous check is never completed.
Is this an issue with Probot and how it handles multiple events?
Beta Was this translation helpful? Give feedback.
All reactions