fix: Add https readiness check for rest-registry tests

ntkathole · ntkathole · commit ea85e63cd9d7 · 2026-02-23T12:43:52.000+05:30
Signed-off-by: ntkathole &lt;nikhilkathole2683@gmail.com&gt;
diff --git a/sdk/python/tests/integration/registration/rest_api/conftest.py b/sdk/python/tests/integration/registration/rest_api/conftest.py
@@ -1,4 +1,5 @@
 import os
+import time
 from pathlib import Path
 
 import pytest
@@ -37,6 +38,44 @@ def get(self, endpoint, params=None):
         return requests.get(url, params=params, verify=False)
 
 
+def _wait_for_http_ready(route_url: str, timeout: int = 180, interval: int = 5) -> None:
+    """
+    Poll the HTTP endpoint until it returns a non-502 response.
+
+    After Pod/CR readiness is confirmed, the backend behind the ingress may
+    still be initializing.  This helper avoids the race condition where tests
+    start before the Feast server is ready, causing all requests to return 502.
+    """
+    health_url = f"{route_url}/api/v1/projects"
+    deadline = time.time() + timeout
+    last_status = None
+
+    print(
+        f"\n Waiting for HTTP endpoint to become ready (timeout={timeout}s): {health_url}"
+    )
+
+    while time.time() < deadline:
+        try:
+            resp = requests.get(health_url, timeout=10, verify=False)
+            last_status = resp.status_code
+            if resp.status_code != 502:
+                print(f" HTTP endpoint is ready (status={resp.status_code})")
+                return
+            print(
+                f" HTTP endpoint returned {resp.status_code}, retrying in {interval}s..."
+            )
+        except requests.exceptions.RequestException as exc:
+            last_status = str(exc)
+            print(f" HTTP request failed ({exc}), retrying in {interval}s...")
+
+        time.sleep(interval)
+
+    raise RuntimeError(
+        f"HTTP endpoint {health_url} did not become ready within {timeout}s "
+        f"(last status: {last_status})"
+    )
+
+
 @pytest.fixture(scope="session")
 def feast_rest_client():
     # Load kubeconfig and initialize Kubernetes client
@@ -142,6 +181,11 @@ def feast_rest_client():
         if not route_url:
             raise RuntimeError("Route URL could not be fetched.")
 
+        # Wait for the HTTP endpoint to become ready before running tests.
+        # Pod/CR readiness does not guarantee the backend is serving traffic;
+        # the ingress may return 502 while the Feast server is still starting.
+        _wait_for_http_ready(route_url)
+
         print(f"\n Connected to Feast REST at: {route_url}")
         yield FeastRestClient(route_url)
 
