Skip to content

fix: fix test JSON repr issues #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacek-prisma merged 1 commit into from
Jan 1, 2026
Merged

fix: fix test JSON repr issues #5719

jacek-prisma merged 1 commit into from
Jan 1, 2026

Conversation

@jacek-prisma
Copy link
Contributor

@jacek-prisma jacek-prisma commented Dec 31, 2025 •
edited
Loading

The safeJsonStringify we use in tests doesn't handle Buffers correctly. We normally would not convert them to JSON in production, but the JSON representation is used for tests snapshots, so I replaced safeJsonStringify with a custom one.

D1 doesn't actually return a Buffer so I just updated its snapshot.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 31, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5719 will not alter performance

Comparing fix/fix-test-json-repr-issues (344e70d) with main (9d980ce)

Summary

✅ 11 untouched
⏩ 11 skipped1

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2025

Wasm Query Compiler File Size

Engine This PR Base branch Diff
Postgres 3.475MiB 3.475MiB 0.000B
Postgres (gzip) 0.000B 0.000B 0.000B
Postgres (size-optimized) 1.741MiB 1.741MiB 0.000B
Postgres (size-optimized, gzip) 0.000B 0.000B 0.000B
Mysql 3.428MiB 3.428MiB 0.000B
Mysql (gzip) 0.000B 0.000B 0.000B
Mysql (size-optimized) 1.711MiB 1.711MiB 0.000B
Mysql (size-optimized, gzip) 0.000B 0.000B 0.000B
Sqlite 3.349MiB 3.349MiB 0.000B
Sqlite (gzip) 0.000B 0.000B 0.000B
Sqlite (size-optimized) 1.667MiB 1.667MiB 0.000B
Sqlite (size-optimized, gzip) 0.000B 0.000B 0.000B
SQL Server 3.570MiB 3.570MiB 0.000B
SQL Server (gzip) 0.000B 0.000B 0.000B
SQL Server (size-optimized) 1.742MiB 1.742MiB 0.000B
SQL Server (size-optimized, gzip) 0.000B 0.000B 0.000B
CockroachDB 3.525MiB 3.525MiB 0.000B
CockroachDB (gzip) 0.000B 0.000B 0.000B
CockroachDB (size-optimized) 1.765MiB 1.765MiB 0.000B
CockroachDB (size-optimized, gzip) 0.000B 0.000B 0.000B

@jacek-prisma jacek-prisma force-pushed the fix/fix-test-json-repr-issues branch from 6229234 to 97727e5 Compare December 31, 2025 16:01
This was referenced Dec 31, 2025
Merged
Merged
@jacek-prisma jacek-prisma force-pushed the fix/fix-test-json-repr-issues branch from 97727e5 to 344e70d Compare December 31, 2025 16:36
@jacek-prisma jacek-prisma merged commit aee8f57 into main Jan 1, 2026
160 of 162 checks passed
@jacek-prisma jacek-prisma deleted the fix/fix-test-json-repr-issues branch January 1, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkomyno jkomyno jkomyno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacek-prisma @jkomyno