Add missing pytz to package dependencies#366
Open
hdh7485 wants to merge 3 commits intopredict-idlab:mainfrom
Open
Add missing pytz to package dependencies#366hdh7485 wants to merge 3 commits intopredict-idlab:mainfrom
hdh7485 wants to merge 3 commits intopredict-idlab:mainfrom
Conversation
pytz is imported in plotly_resampler/aggregation/plotly_aggregator_parser.py but was not declared as a dependency in pyproject.toml, causing ModuleNotFoundError in clean environments. Fixes predict-idlab#365
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
- Coverage 83.83% 83.27% -0.56%
==========================================
Files 13 13
Lines 1206 1232 +26
==========================================
+ Hits 1011 1026 +15
- Misses 195 206 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pytzto[tool.poetry.dependencies]inpyproject.tomlpytzis imported inplotly_resampler/aggregation/plotly_aggregator_parser.py(line 8) but was not declared as a dependencyProblem
In clean environments (CI, Docker, fresh virtualenvs), importing
plotly_resamplerfails with:This happens because
pytzis often installed as a transitive dependency of other packages, masking the missing declaration.Fix
Added
pytz = ">=2020.1"to the package dependencies.Fixes #365