Only create the directory if it does not exist#1007
Open
Rumiya wants to merge 1 commit intopointfreeco:mainfrom
Open
Only create the directory if it does not exist#1007Rumiya wants to merge 1 commit intopointfreeco:mainfrom
Rumiya wants to merge 1 commit intopointfreeco:mainfrom
Conversation
Rumiya
force-pushed
the
rumiya/only-create-directory-when-not-present
branch
from
a9876a2 to
8f8114b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in a CI setup using
xcodebuild build-for-testing/xcodebuild test-without-running, the snapshot folder inside the test bundle might not be writable and tests fail becauseFileManager.createDirectory()attempts to create the directory regardless if it exists or not and fails with a permission denied error.This adds a preflight check and only attempts to create the folder when it doesn't already exist.