fix: keep the ignoredBuilds field when installing different pkg
#9242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What if the ignored package was uninstalled? |
Member
Author
|
I tested it, and it seems that the information is correctly removed from |
Any update on this? |
zkochan
approved these changes
Mar 19, 2025
Member
|
Now it duplicates the same fix at |
zkochan
added a commit
that referenced
this pull request
Mar 19, 2025
) * fix: keep the `ignoredBuilds` field when installing different dependencies * fix: print warning about ignored builds --------- close #9240 Co-authored-by: Zoltan Kochan <[email protected]>
Member
Author
|
I agree that repeated logic can be moved together to prevent omissions in subsequent similar operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9240