allow to specify identifier when creating object

martiner · martiner · commit e3c9985ca0a2 · 2017-08-30T13:18:26.000+02:00
Close: gooddata#508
diff --git a/src/main/java/com/gooddata/md/MetadataService.java b/src/main/java/com/gooddata/md/MetadataService.java
@@ -52,7 +52,7 @@ public <T extends Obj> T createObj(Project project, T obj) {
 
         final T response;
         try {
-            response = restTemplate.postForObject(Obj.CREATE_URI, obj, (Class<T>)obj.getClass(), project.getId());
+            response = restTemplate.postForObject(Obj.CREATE_WITH_ID_URI, obj, (Class<T>)obj.getClass(), project.getId());
         } catch (GoodDataRestException | RestClientException e) {
             throw new ObjCreateException(obj, e);
         }
diff --git a/src/main/java/com/gooddata/md/Obj.java b/src/main/java/com/gooddata/md/Obj.java
@@ -14,6 +14,7 @@ public interface Obj {
 
     String URI = "/gdc/md/{projectId}/obj";
     String CREATE_URI = URI + "?createAndGet=true";
+    String CREATE_WITH_ID_URI = CREATE_URI + "&setIdentifier=true";
     String OBJ_URI = URI + "/{objId}";
     UriTemplate OBJ_TEMPLATE = new UriTemplate(OBJ_URI);
 
diff --git a/src/test/java/com/gooddata/md/MetadataServiceAT.java b/src/test/java/com/gooddata/md/MetadataServiceAT.java
@@ -59,7 +59,10 @@ public void updateObj() throws Exception {
     @Test(groups = "md", dependsOnMethods = "getObjs")
     public void createMetric() throws Exception {
         final MetadataService md = gd.getMetadataService();
-        metric = md.createObj(project, new Metric("Avg shoe size", "SELECT AVG([" + fact + "])", "#,##0"));
+        final Metric create = new Metric("Avg shoe size", "SELECT AVG([" + fact + "])", "#,##0");
+        create.setIdentifier("metric.avgshoesize");
+        metric = md.createObj(project, create);
+        assertThat(metric.getIdentifier(), is("metric.avgshoesize"));
     }
 
     @Test(groups = "md", dependsOnMethods = "createMetric")
diff --git a/src/test/java/com/gooddata/md/MetadataServiceTest.java b/src/test/java/com/gooddata/md/MetadataServiceTest.java
@@ -85,7 +85,7 @@ public void testCreateObj() throws Exception {
         final Obj obj = mock(Obj.class);
         final Obj resultObj = mock(Obj.class);
 
-        when(restTemplate.postForObject(eq(Obj.CREATE_URI), eq(obj), Matchers.<Class<Obj>>any(), eq(PROJECT_ID)))
+        when(restTemplate.postForObject(eq(Obj.CREATE_WITH_ID_URI), eq(obj), Matchers.<Class<Obj>>any(), eq(PROJECT_ID)))
                 .thenReturn(resultObj);
 
         final Obj result = service.createObj(project, obj);

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public <T extends Obj> T createObj(Project project, T obj) {`
`52`	`52`
`53`	`53`	`final T response;`
`54`	`54`	`try {`
`55`		`- response = restTemplate.postForObject(Obj.CREATE_URI, obj, (Class<T>)obj.getClass(), project.getId());`
	`55`	`+ response = restTemplate.postForObject(Obj.CREATE_WITH_ID_URI, obj, (Class<T>)obj.getClass(), project.getId());`
`56`	`56`	`} catch (GoodDataRestException \| RestClientException e) {`
`57`	`57`	`throw new ObjCreateException(obj, e);`
`58`	`58`	`}`