Skip to content

1556 : Update PlayJUnitExtension.java with new implementation#1560

Draft
xael-fry wants to merge 3 commits intoplayframework:masterfrom
xael-fry:fix/tests-play-thread
Draft

1556 : Update PlayJUnitExtension.java with new implementation#1560
xael-fry wants to merge 3 commits intoplayframework:masterfrom
xael-fry:fix/tests-play-thread

Conversation

@xael-fry
Copy link
Member

@xael-fry xael-fry commented Mar 1, 2026

Pull Request Checklist

Helpful things

Fixes

Fixes #1556

@xael-fry xael-fry changed the title Update PlayJUnitExtension.java with new implementation 1556 : Update PlayJUnitExtension.java with new implementation Mar 1, 2026
@xael-fry xael-fry marked this pull request as draft March 1, 2026 17:22
@xael-fry xael-fry force-pushed the fix/tests-play-thread branch from cad3996 to 83c944e Compare March 1, 2026 17:24
@xael-fry xael-fry self-assigned this Mar 2, 2026
@xael-fry xael-fry added this to the 1.12.0 milestone Mar 2, 2026
@xael-fry xael-fry linked an issue Mar 2, 2026 that may be closed by this pull request
@xael-fry
Copy link
Member Author

xael-fry commented Mar 14, 2026

It is working for me now, can other try ?

image

@xael-fry xael-fry marked this pull request as ready for review March 14, 2026 13:19
@aleksandy
Copy link
Contributor

I just tried to run all the tests in samples-and-tests/just-test-cases, and most of them didn't even run, failing with the error.

Success tests
  • JPAEntitiesTest
  • TimeTest
  • PhoneValidationTest
  • WSTest
  • Promises
  • OrphanTest
  • OptimisticLockingModelPlayTest
  • TransactionalJPATest
  • ByteCodeCacheTest
  • FunctionalTestTest$AnotherInnerTest
  • DirectBindingTest
  • XForwardedSupportTest
  • RedirectTest
  • ApplicationTest
  • MvcObjectFunctionalTest
  • OpenIDTest
  • Functions
  • OptimisticLockingModelTest
  • FunctionalTestCleanTest
  • ConfigTest
  • IPValidationTest

Some tests are failed because of assertions

  • MessagesTest

    #testMessageInAnotherLanguage
    org.opentest4j.AssertionFailedError: 
    Expected :Last login February 2013
    Actual   :Last login февраля 2013
    
    at MessagesTest.testMessageInAnotherLanguage(MessagesTest.java:37)
    
  • TemplateClassBindingTest

    #testDynamicClassBindingWithInstanceOf
    org.opentest4j.AssertionFailedError: 
    Expected :true
    Actual   :false
    
    at TemplateClassBindingTest.testDynamicClassBindingWithInstanceOf(TemplateClassBindingTest.java:35)
    
    #testDynamicClassBindingWithDotClass
    org.opentest4j.AssertionFailedError: 
    Expected :true
    Actual   :false
    
    at TemplateClassBindingTest.testDynamicClassBindingWithDotClass(TemplateClassBindingTest.java:46)
    
  • Chunked2Test

    #testChunked2
    org.opentest4j.AssertionFailedError: 
    Expected :Go, Go, Igo!
    Actual   :null
    
    at Chunked2Test.testChunked2(Chunked2Test.java:47)
    
Some failed tests
  • SimpleJPATest

  • UniqueTest

  • BinaryTest

  • CompositeIdFactoryTest

  • CascadeAllTest

  • JPAPluginTest

  • CompositeIdBinderTest

  • FixturesTest

  • FunctionalTestTest

  • CascadeTest

  • CacheTest

  • CompositeIdJPATest

    Trace
    ```
    java.lang.RuntimeException: Cannot delete all table data : No active EntityManager for name [default], transaction not started?
    
      at play.test.Fixtures.deleteDatabase(Fixtures.java:177)
      at play.test.Fixtures.deleteAll(Fixtures.java:144)
      at SimpleJPATest.setup(SimpleJPATest.java:12)
      at java.base/java.lang.reflect.Method.invoke(Method.java:569)
      at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
      at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
    Caused by: play.exceptions.DatabaseException: No active EntityManager for name [default], transaction not started?
      at play.db.DB.getConnection(DB.java:195)
      at play.db.DB.getConnection(DB.java:200)
      at play.test.Fixtures.deleteDatabase(Fixtures.java:156)
      ... 5 more
    ```
    
  • YamlTest

    Trace
    java.lang.UnsupportedOperationException: Please annotate your JPA model with @jakarta.persistence.Entity annotation.
    
      at play.db.jpa.GenericModel.findById(GenericModel.java:474)
      at YamlTest.testYamlLoadingNotAsTemplate(YamlTest.java:46)
      at java.base/java.lang.reflect.Method.invoke(Method.java:569)
      at play.test.PlayJUnitExtension$1.execute(PlayJUnitExtension.java:72)
      at play.Invoker$Invocation.lambda$run$0(Invoker.java:317)
      at play.db.jpa.JPA.withTransaction(JPA.java:280)
      at play.db.jpa.JPA.withinFilter(JPA.java:233)
      at play.db.jpa.JPAPlugin$TransactionalFilter.withinFilter(JPAPlugin.java:296)
    
  • CustomEncodingTest

    Trace
    java.net.ConnectException: Connection refused: localhost/127.0.0.1:9003
    
      at java.base/sun.nio.ch.Net.pollConnect(Native Method)
      at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:672)
      at java.base/sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:946)
      at org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
      at org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
      at org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
      at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
      at org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
    
  • PropertiesEnhancerTest

    Trace
    java.lang.NoSuchMethodException: Unknown property 'name' on class 'class models.Project'
    
      at org.apache.commons.beanutils.PropertyUtilsBean.getSimpleProperty(PropertyUtilsBean.java:1232)
      at org.apache.commons.beanutils.PropertyUtilsBean.getNestedProperty(PropertyUtilsBean.java:783)
      at org.apache.commons.beanutils.PropertyUtilsBean.getProperty(PropertyUtilsBean.java:811)
      at org.apache.commons.beanutils.PropertyUtils.getProperty(PropertyUtils.java:396)
      at classloading.enhancers.PropertiesEnhancerTest.testEnhancerProperty(PropertiesEnhancerTest.java:78)
      at java.base/java.lang.reflect.Method.invoke(Method.java:569)
      at play.test.PlayJUnitExtension$1.execute(PlayJUnitExtension.java:72)
      at play.Invoker$Invocation.lambda$run$0(Invoker.java:317)
    
  • DataBindingUnitTest

    Trace
      java.lang.ClassCastException: class models.City cannot be cast to class models.City (models.City is in unnamed module of loader 'app'; models.City is in unnamed module of loader play.classloading.ApplicationClassloader @4441d567)
    
        at models.City$HibernateAccessOptimizer5name.getPropertyValues(Unknown Source)
        at org.hibernate.persister.entity.AbstractEntityPersister.getPropertyValues(AbstractEntityPersister.java:4662)
        at org.hibernate.persister.entity.EntityPersister.getValues(EntityPersister.java:1104)
        at org.hibernate.event.internal.DefaultDeleteEventListener.deleteEntity(DefaultDeleteEventListener.java:381)
        at org.hibernate.event.internal.DefaultDeleteEventListener.delete(DefaultDeleteEventListener.java:248)
        at org.hibernate.event.internal.DefaultDeleteEventListener.deletePersistentInstance(DefaultDeleteEventListener.java:224)
        at org.hibernate.event.internal.DefaultDeleteEventListener.delete(DefaultDeleteEventListener.java:164)
        at org.hibernate.event.internal.DefaultDeleteEventListener.onDelete(DefaultDeleteEventListener.java:100)
    

@xael-fry xael-fry marked this pull request as draft March 20, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when running tests with fixture in IntelliJ

2 participants