refactor(test): remove tap from db-authorization tests#1814
Merged
mcollina merged 6 commits intoplatformatic:mainfrom Nov 20, 2023
Merged
refactor(test): remove tap from db-authorization tests#1814mcollina merged 6 commits intoplatformatic:mainfrom
mcollina merged 6 commits intoplatformatic:mainfrom
Conversation
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
12 tasks
Signed-off-by: mateonunez <[email protected]>
Signed-off-by: mateonunez <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the #1796 by migrating tests from
taptonode:test.Currently Node runs all tests in parallel and this can generate concurrency problems with the external database to run the test operations. To avoid this I implemented a
runnerfile that retrieves all the tests and runs them one at a time. It will be possible to remove the runner when nodejs/node#49996 is released in Node v18 and v20.Migrated test