Skip to content

build(zone.js): add changelog gulptask for zone.js#31852

Closed
JiaLiPassion wants to merge 1 commit into
angular:masterfrom
JiaLiPassion:changelog
Closed

build(zone.js): add changelog gulptask for zone.js#31852
JiaLiPassion wants to merge 1 commit into
angular:masterfrom
JiaLiPassion:changelog

Conversation

@JiaLiPassion

@JiaLiPassion JiaLiPassion commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

  1. add gulp task to generate zone.js changelog
  2. update zone.js changelog.

Does this PR introduce a breaking change?

  • Yes
  • No

Now this process is still not fully automatically, because by default the changelog gulp task will generate something like

+<a name="8.2.0-next.2"></a>
+# [8.2.0-next.2](https://github.com/angular/angular/compare/2.3.0-rc.0...8.2.0-next.2) (2019-07-26)
+
+
+### Bug Fixes

So the tag will be the angular repo version.

And I am not sure whether we should tag zone.js (for example: 0.10.0) for each release, because this tag will also visible for all angular mono repo.
So if we don't make such kind of tags, we have to use the angular tag. which will be something like 8.2.0-next.2, and in this PR, I modified it to 0.10.0 manually, I am not sure how to deal with this step.

Please review, thanks.

@JiaLiPassion JiaLiPassion requested review from a team, gkalpak and mhevery July 26, 2019 07:36
@googlebot

googlebot commented Jul 26, 2019

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot

googlebot commented Jul 26, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gkalpak
gkalpak approved these changes Jul 26, 2019
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but need to figure out what to do about the tagging 😁

Comment thread tools/gulp-tasks/changelog.js Outdated
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project area: zones Issues related to zone.js action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Jul 26, 2019
@ngbot ngbot Bot modified the milestone: needsTriage Jul 26, 2019
@JiaLiPassion

JiaLiPassion commented Jul 26, 2019

Copy link
Copy Markdown
Contributor Author

@gkalpak , thank you for the review.

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jul 26, 2019
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 26, 2019
@ngbot

ngbot Bot commented Jul 26, 2019

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci-codefresh-bazel" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mhevery mhevery self-assigned this Jul 26, 2019
mhevery pushed a commit that referenced this pull request Jul 26, 2019
@JiaLiPassion @mhevery
build(zone.js): add changelog gulptask for zone.js (#31852)
fa15814 
PR Close #31852
@mhevery mhevery closed this in 3067309 Jul 26, 2019
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@JiaLiPassion @sabeersulaiman
build(zone.js): add changelog gulptask for zone.js (angular#31852)
f841a56 
PR Close angular#31852
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mhevery mhevery mhevery approved these changes
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mhevery mhevery

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: zones Issues related to zone.js cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

4 participants

@JiaLiPassion @googlebot @mhevery @gkalpak