Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: KnpLabs/php-github-api
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pilotmoon/php-github-api
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 0 files changed
  • 1 contributor

Commits on Apr 26, 2013

  1. Revert "Force object-form when encoding json for sending as POST body" 

    This reverts commit 85c2994.

This change breaks issue creation. An array of labels in the parameters to api('issue')->create()

    'labels'=>array('label1','label2)

should be encoded as:

    "labels":{"label1","label2"}

but with JSON_FORCE_OBJECT it is encoded as

    "labels":{"0":"label1","1":"label2"}

which fails validation and results in 422 Unprocessable Entity.
    @pilotmoon
    pilotmoon committed Apr 26, 2013
    Configuration menu
    Copy the full SHA
    ccba4e0 View commit details
    Browse the repository at this point in the history

  2. Update JSON_FORCE_OBJECT usage based on whether params are empty

    @pilotmoon
    pilotmoon committed Apr 26, 2013
    Configuration menu
    Copy the full SHA
    ab72463 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:invariant/php-github-api

    @pilotmoon
    pilotmoon committed Apr 26, 2013
    Configuration menu
    Copy the full SHA
    697b4be View commit details
    Browse the repository at this point in the history
Loading