Add homebrew support for bz2 and iconv#1118
Merged
morozov merged 1 commit intophpbrew:masterfrom Dec 22, 2019
markwu:fix-homebrew-dependency-for-bz2andiconv
Merged
Add homebrew support for bz2 and iconv#1118morozov merged 1 commit intophpbrew:masterfrom markwu:fix-homebrew-dependency-for-bz2andiconv
morozov merged 1 commit intophpbrew:masterfrom
markwu:fix-homebrew-dependency-for-bz2andiconv
Conversation
Contributor
This will need to be taken care of separately. Thanks @markwu! |
morozov
approved these changes
Dec 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add homebrew dependency support for bz2 and iconv. Now, you don't need to do
+bz2=$(brew --prefix bz2)and+iconv=$(brew --prefix iconv), just+bz2and+iconvis enough.But, this only works for
phpbrew install, not forphpbrew ext install, you still need to assign prefix as before.