Cleaned up the test suite a bit#1070
Merged
morozov merged 1 commit intophpbrew:masterfrom Dec 7, 2019
morozov:test-suite-cleanup
Merged
Cleaned up the test suite a bit#1070morozov merged 1 commit intophpbrew:masterfrom morozov:test-suite-cleanup
morozov merged 1 commit intophpbrew:masterfrom
morozov:test-suite-cleanup
Conversation
1. Removed test coverage and logging enabled by default. 2. Validated the configuration against the XSD and removed redundant parameters. 3. Removed the breakdown by test suites. All tests are important, slow tests will be moved out later. 4. Fixed accidental failures VariantBuilderTest. Depending on the environment, the configure options may or may not have the path specified and it's okay and should not be enforced by the test. 5. Got rid of custom assertions like ok(). They are too unspecific. The rest will have to go later.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VariantBuilderTest. Depending on the environment, the configure options may or may not have the path specified and it's okay and should not be enforced by the test.ok(). They are too unspecific. The rest will have to go later.