Exempt adding Type and Value Errors from BC break policy#27
Open
Exempt adding Type and Value Errors from BC break policy#27
Conversation
theodorejb
reviewed
Mar 2, 2026
Co-authored-by: Theodore Brown <[email protected]>
ramsey
reviewed
Mar 21, 2026
|
|
||
| - Adding TypeError and ValueError exceptions to validate inputs to functions | ||
| and methods. These are not classified as BC breaks because not adding them | ||
| allows incorrect code to run and thus leads to hard to debug code. |
Member
There was a problem hiding this comment.
Add hyphens to turn the adjective phrase into a compound word, increasing readability.
Suggested change
| allows incorrect code to run and thus leads to hard to debug code. | |
| allows incorrect code to run and thus leads to hard-to-debug code. |
iluuu1994
reviewed
Mar 24, 2026
|
|
||
| - Adding TypeError and ValueError exceptions to validate inputs to functions | ||
| and methods. These are not classified as BC breaks because not adding them | ||
| allows incorrect code to run and thus leads to hard to debug code. |
Member
There was a problem hiding this comment.
These are not classified as BC breaks because not adding them allows incorrect code to run and thus leads to hard to debug code.
IMO this wording is not great. Maybe:
Missing validation for undocumented or clearly unintended argument values are considered PHP core bugs with unpredictable or incorrect behavior. As such, adding the desired validation is not considered BC breaking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.