fileinfo: don't compile libmagic/strcasestr.c#21522
Merged
iluuu1994 merged 3 commits intophp:masterfrom Mar 25, 2026
Merged
Conversation
PHP's copy of libmagic doesn't use the strcasestr() function, so there is no reason to prototype it, regardless of whether or not the OS (libc) provides it.
Run ext/fileinfo/generate_patch.sh to re-roll this patch, a recent commit removes HAVE_STRCASESTR from PHP's copy of libmagic.
Unlike the upstream library, PHP's copy of libmagic doesn't use the strcasestr() function, so there is no reason to include strcasestr.c in the list of source files.
Member
|
Thank you @orlitzky! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #21472
PHP's copy of libmagic does not use the
strcasestr()function, so there is no need to check for it or compile the fallback implementation.This leaves
libmagic/strcasestr.cunused, but since we are maintaining a patch against upstream libmagic, removing the file (and including the removal in the patch) is not a clear win.