Always render the search results page even if no images#506
Merged
Meow merged 2 commits intophilomena-dev:masterfrom May 2, 2025
Merged
Always render the search results page even if no images#506Meow merged 2 commits intophilomena-dev:masterfrom
Meow merged 2 commits intophilomena-dev:masterfrom
Conversation
MareStare
approved these changes
Apr 28, 2025
Contributor
MareStare
left a comment
MareStare
left a comment
There was a problem hiding this comment.
Tested this locally. Seems okay to merge.
Before:
After:
Comment on lines
-8
to
-9
| tag.images_count > 0 or Enum.any?(dnp_entries) or | ||
| (present?(tag.mod_notes) and can?(conn, :edit, tag)) |
Contributor
There was a problem hiding this comment.
Do you know what was all this complicated logic about? Seems rather convoluted given that it only influenced wether you saw the empty image view or not
Contributor
Author
There was a problem hiding this comment.
It became complicated only recently, used to be just any?(images). I don't think it was ever worth it
MareStare
added
the
qa accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you begin
closes #496