Make it a setting staff can toggle on/off, i can see it being useful to see what users see.

I'm curious why do this if you can use search *?

Make it a setting staff can toggle on/off, i can see it being useful to see what users see.

I added a new setting in a way that defaults to true for normal users and false for staff.

I'm curious why do this if you can use search *?

I've had this behavior in a userscript for probably over a year and it's really convenient to see new images on the home page directly, e.g. to find your own uploads.

QA

Images without thumbnails are shown by default for Administrator. If this setting is enabled:

then images without thumbnails are not shown.

Regular users also have access to this setting, but the delay is enabled by default for them.

Not clear why we need separate staff_delay_home_images and delay_home_images boolean configs. @mdashlw what's the reason to make two different fields here? Couldn't we just use a single field here?

@MareStare for different defaults for regular users and staff

for different defaults for regular users and staff

I see, Postgres doesn't allow using other columns of the row in the DEFAULT expression or subqueries. However, we could just make the delay_home_images column nullable, and handle defaulting at the application code level. That might be cleaner.

The existing code already has a similar logic at app level where it selects which of the fields to use (staff_ one or the regular one). Instead, it could check

if(is_nil(user.delay_home_images), do: user.role == "user", else: user.delay_home_images)

@MareStare feel free to do this if you want.

After I did this change (#561) I realized that with my suggested approach the following unwanted scenario will happen:

• User creates a fresh account
• User goes to its "Display" settings, the default delay_home_images: true checkbox is set.
• User changes the values of unrelated settings, and clicks "save"
• The value true is now set in the DB column delay_home_images instead of null (taken from the checkbox from Frontend)
• The user is promoted to a staff user
• The user already has the value true in delay_home_images, so its delay_home_images stays true even after they became staff

With separate staff_delay_home_images and delay_home_images columns the value of delay changes appropriately when the user is promoted/demoted to/from staff automatically. So, better keep it this way