Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bloominstituteoftechnology/Sprint-Challenge--JavaScript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pghrogue/Sprint-Challenge--JavaScript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 6 files changed
  • 1 contributor

Commits on Aug 25, 2018

  1. Initial pull request.

    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    f79310a View commit details
    Browse the repository at this point in the history

  2. Answered all questions in Answers.md

    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    c7386d4 View commit details
    Browse the repository at this point in the history

  3. objects-arrays.js: finished "Object" and "Array" sections. Working on… 

    … "Array Methods" next.
    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    e82ff7a View commit details
    Browse the repository at this point in the history

  4. Added sort method to Array section for const universities. 

    Finished Array Method section.
May go back to this to change sort method later.
    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    879a42f View commit details
    Browse the repository at this point in the history

  5. functions.js: finished callbacks section. 

    Working on Closures
    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    667c402 View commit details
    Browse the repository at this point in the history

  6. Finished closure section of functions.js

    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    66245b8 View commit details
    Browse the repository at this point in the history

  7. Finished prototypes.js. This was quick, did not need multiple commits.

    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    b8691e3 View commit details
    Browse the repository at this point in the history

  8. Finished classes.js - Need to work on stretch goals next.

    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    20f1682 View commit details
    Browse the repository at this point in the history

  9. Added CubeMaker class for stretch goal.

    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    398e20c View commit details
    Browse the repository at this point in the history

  10. Added sortArray function to demonstrate 2 different ways of sorting a… 

    …n array.

1. using the .sort() method
2. sorting by hand using for & while

Syntax:
sortArray( arr, type='old' );

Returns:
sortedArray;
    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    825c93f View commit details
    Browse the repository at this point in the history

  11. Didn't need 2 lines in sortArray()

    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    1918379 View commit details
    Browse the repository at this point in the history

  12. Bug fix in sortArray(). Needed to set lowest to tempArray[0] instead … 

    …of ''.
    @pghrogue
    pghrogue committed Aug 25, 2018
    Configuration menu
    Copy the full SHA
    723566d View commit details
    Browse the repository at this point in the history
Loading