chore: add image_tag as a param (googleapis#10962)

JoeWang1127 · web-flow · commit 8e554b7cc967 · 2024-06-13T12:07:47.000-07:00
diff --git a/.github/scripts/hermetic_library_generation.sh b/.github/scripts/hermetic_library_generation.sh
@@ -21,7 +21,9 @@ set -e
 # The parameters of this script is:
 # 1. target_branch, the branch into which the pull request is merged.
 # 2. current_branch, the branch with which the pull request is associated.
-# 3. [optional] generation_config, the path to the generation configuration,
+# 3. [optional] image_tag, the tag of gcr.io/cloud-devrel-public-resources/java-library-generation.
+# The value will be parsed from the generation configuration if not specified.
+# 4. [optional] generation_config, the path to the generation configuration,
 # the default value is generation_config.yaml in the repository root.
 while [[ $# -gt 0 ]]; do
 key="$1"
@@ -34,6 +36,10 @@ case "${key}" in
     current_branch="$2"
     shift
     ;;
+  --image_tag)
+    image_tag="$2"
+    shift
+    ;;
   --generation_config)
     generation_config="$2"
     shift
@@ -56,6 +62,10 @@ if [ -z "${current_branch}" ]; then
   exit 1
 fi
 
+if [ -z "${image_tag}" ]; then
+  image_tag=$(grep "gapic_generator_version" "${generation_config}" | cut -d ':' -f 2 | xargs)
+fi
+
 if [ -z "${generation_config}" ]; then
   generation_config=generation_config.yaml
   echo "Use default generation config: ${generation_config}"
@@ -78,9 +88,6 @@ fi
 git show "${target_branch}":"${generation_config}" > "${baseline_generation_config}"
 config_diff=$(diff "${generation_config}" "${baseline_generation_config}" || true)
 
-# parse image tag from the generation configuration.
-image_tag=$(grep "gapic_generator_version" "${generation_config}" | cut -d ':' -f 2 | xargs)
-
 # run hermetic code generation docker image.
 docker run \
   --rm \
