report line and column number in python editor

Roberto De Ioris · Roberto De Ioris · commit 7492710b9177 · 2017-08-24T13:16:06.000+02:00
diff --git a/Source/PythonEditor/Private/SPythonEditableText.cpp b/Source/PythonEditor/Private/SPythonEditableText.cpp
@@ -6,7 +6,6 @@
 
 void SPythonEditableText::Construct(const FArguments& InArgs)
 {
-
 	SMultiLineEditableText::Construct(
 		SMultiLineEditableText::FArguments()
 		.Font(FPythonEditorStyle::Get().GetWidgetStyle<FTextBlockStyle>("TextEditor.NormalText").Font)
@@ -18,7 +17,8 @@ void SPythonEditableText::Construct(const FArguments& InArgs)
 		.HScrollBar(InArgs._HScrollBar)
 		.VScrollBar(InArgs._VScrollBar)
 		.OnTextChanged(InArgs._OnTextChanged)
-		);
+		.OnCursorMoved(this, &SPythonEditableText::OnCursorMoved)
+	);
 	OnExecuted = InArgs._OnExecuted;
 }
 
@@ -92,3 +92,9 @@ FReply SPythonEditableText::OnKeyDown(const FGeometry& MyGeometry, const FKeyEve
 	return Reply;
 }
 
+void SPythonEditableText::GetLineAndColumn(int32 & Line, int32 & Column)
+{
+	Line = CurrentLine;
+	Column = CurrentColumn;
+}
+
diff --git a/Source/PythonEditor/Private/SPythonEditableText.h b/Source/PythonEditor/Private/SPythonEditableText.h
@@ -29,9 +29,19 @@ class SPythonEditableText : public SMultiLineEditableText
 
 	void Construct( const FArguments& InArgs );
 
+	void GetLineAndColumn(int32 & Line, int32 & Column);
+
+	void OnCursorMoved(const FTextLocation & Location) {
+		CurrentLine = Location.GetLineIndex();
+		CurrentColumn = Location.GetOffset();
+	}
+
 private:
 	virtual FReply OnKeyChar(const FGeometry& MyGeometry,const FCharacterEvent& InCharacterEvent) override;
 	virtual FReply OnKeyDown(const FGeometry& MyGeometry, const FKeyEvent& InKeyEvent) override;
 
 	FOnExecuted OnExecuted;
+
+	int32 CurrentLine;
+	int32 CurrentColumn;
 };
diff --git a/Source/PythonEditor/Private/SPythonEditor.cpp b/Source/PythonEditor/Private/SPythonEditor.cpp
@@ -40,7 +40,7 @@ void SPythonEditor::Construct(const FArguments& InArgs, UPythonProjectItem* InPy
 		[
 			SNew(SGridPanel)
 			.FillColumn(0, 1.0f)
-			.FillRow(0, 1.0f)
+			.FillRow(0, 2.0f)
 			+SGridPanel::Slot(0, 0)
 			[
 				SAssignNew(PythonEditableText, SPythonEditableText)
@@ -59,7 +59,16 @@ void SPythonEditor::Construct(const FArguments& InArgs, UPythonProjectItem* InPy
 			[
 				HorizontalScrollbar.ToSharedRef()
 			]
+			+ SGridPanel::Slot(0, 2)
+			[
+				SNew(SBorder).HAlign(EHorizontalAlignment::HAlign_Right)
+				[
+					SNew(STextBlock)
+					.Text(this, &SPythonEditor::GetLineAndColumn)
+				]
+			]
 		]
+		
 	];
 }
 
@@ -119,4 +128,15 @@ void SPythonEditor::GotoLineAndColumn(int32 LineNumber, int32 ColumnNumber)
 	PythonEditableText->ScrollTo(Location);
 }
 
+FText SPythonEditor::GetLineAndColumn() const
+{
+	int32 Line;
+	int32 Column;
+	PythonEditableText->GetLineAndColumn(Line, Column);
+	
+	FString LineAndColumn = FString::Printf(TEXT("Line: %d Column: %d"), Line, Column);
+	
+	return FText::FromString(LineAndColumn);
+}
+
 #undef LOCTEXT_NAMESPACE
diff --git a/Source/PythonEditor/Private/SPythonEditor.h b/Source/PythonEditor/Private/SPythonEditor.h
@@ -22,6 +22,7 @@ class SPythonEditor : public SCompoundWidget
 
 private:
 	void OnTextChanged(const FText& NewText);
+	FText GetLineAndColumn() const;
 
 protected:
 	class UPythonProjectItem* PythonProjectItem;

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ void SPythonEditor::Construct(const FArguments& InArgs, UPythonProjectItem* InPy`
`40`	`40`	`[`
`41`	`41`	`SNew(SGridPanel)`
`42`	`42`	`.FillColumn(0, 1.0f)`
`43`		`- .FillRow(0, 1.0f)`
	`43`	`+ .FillRow(0, 2.0f)`
`44`	`44`	`+SGridPanel::Slot(0, 0)`
`45`	`45`	`[`
`46`	`46`	`SAssignNew(PythonEditableText, SPythonEditableText)`
`@@ -59,7 +59,16 @@ void SPythonEditor::Construct(const FArguments& InArgs, UPythonProjectItem* InPy`
`59`	`59`	`[`
`60`	`60`	`HorizontalScrollbar.ToSharedRef()`
`61`	`61`	`]`
	`62`	`+ + SGridPanel::Slot(0, 2)`
	`63`	`+ [`
	`64`	`+ SNew(SBorder).HAlign(EHorizontalAlignment::HAlign_Right)`
	`65`	`+ [`
	`66`	`+ SNew(STextBlock)`
	`67`	`+ .Text(this, &SPythonEditor::GetLineAndColumn)`
	`68`	`+ ]`
	`69`	`+ ]`
`62`	`70`	`]`
	`71`	`+`
`63`	`72`	`];`
`64`	`73`	`}`
`65`	`74`
`@@ -119,4 +128,15 @@ void SPythonEditor::GotoLineAndColumn(int32 LineNumber, int32 ColumnNumber)`
`119`	`128`	`PythonEditableText->ScrollTo(Location);`
`120`	`129`	`}`
`121`	`130`
	`131`	`+FText SPythonEditor::GetLineAndColumn() const`
	`132`	`+{`
	`133`	`+ int32 Line;`
	`134`	`+ int32 Column;`
	`135`	`+ PythonEditableText->GetLineAndColumn(Line, Column);`
	`136`	`+`
	`137`	`+ FString LineAndColumn = FString::Printf(TEXT("Line: %d Column: %d"), Line, Column);`
	`138`	`+`
	`139`	`+ return FText::FromString(LineAndColumn);`
	`140`	`+}`
	`141`	`+`
`122`	`142`	`#undef LOCTEXT_NAMESPACE`