#define PyString_FromStringAndSize -> PyUnicode_FromStringAndSize#32
Closed
adisbladis wants to merge 1 commit intooremanj:masterfrom
Closed
#define PyString_FromStringAndSize -> PyUnicode_FromStringAndSize#32adisbladis wants to merge 1 commit intooremanj:masterfrom
adisbladis wants to merge 1 commit intooremanj:masterfrom
Conversation
Collaborator
|
Thanks for the contribution and my apologies for ignoring it. Updating netfilterqueue.c is not ideal because it's the generated output from Cython. The .c file is only included in the source so it can be used without Cython. If this PR was accepted as-is, it would be reverted the next time someone submitted a change to the .pyx. Unfortunately it's been a while since I've done any Cython and I'm not sure off the top of my head what Cython results in a |
Author
|
I'm not using this software any more and am therefore not interested in pushing this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Opensnitch we had some Gentoo users with issues related to this (evilsocket/opensnitch#69).