An empty string doesn't work around the 411 issue on PUTs. Use 'PLACEHOLDER'

stefanor · stefanor · commit b488b8447fc9 · 2012-04-24T09:10:54.000+02:00
diff --git a/pygithub3/services/base.py b/pygithub3/services/base.py
@@ -105,10 +105,10 @@ def _patch(self, request, **kwargs):
     def _put(self, request, **kwargs):
         """ Bug in Github API? requests library?
 
-        I must send data as empty string when the specifications' of some PUT
-        request are 'Not send input data'. If I don't do that and send data as
-        None, the requests library doesn't send 'Content-length' header and the
-        server returns 411 - Required Content length (at least 0)
+        I must send data when the specifications' of some PUT request are 'Not
+        send input data'. If I don't do that and send data as None, the
+        requests library doesn't send 'Content-length' header and the server
+        returns 411 - Required Content length (at least 0)
 
         For instance:
             - follow-user request doesn't send input data
@@ -119,7 +119,7 @@ def _put(self, request, **kwargs):
 
         Related: https://github.com/github/developer.github.com/pull/52
         """
-        input_data = request.get_body() or ''
+        input_data = request.get_body() or 'PLACEHOLDER'
         response = self._client.put(request, data=input_data, **kwargs)
         if response.status_code != 204:  # != NO_CONTENT
             return request.resource.loads(response.content)
diff --git a/pygithub3/tests/services/test_core.py b/pygithub3/tests/services/test_core.py
@@ -27,7 +27,7 @@ def test_BOOL(self, request_method):
 
     def test_PUT(self, request_method):
         self.s._put(self.r, **self.args)
-        data = ''  # See _put
+        data = 'PLACEHOLDER'  # See _put
         request_method.assert_called_with('put', _('dummyrequest'),
                                           data=data, params=self.args)
 
