Fix lints and improve formatting #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobozaur
force-pushed
the
fix/lints_and_format
branch
5 times, most recently
from
927a7ac to
339bb1b
Compare
Codecov Report
@@ Coverage Diff @@
## main #986 +/- ##
==========================================
+ Coverage 29.27% 30.04% +0.76%
==========================================
Files 417 415 -2
Lines 26096 26943 +847
Branches 5222 5229 +7
==========================================
+ Hits 7640 8095 +455
- Misses 16262 16651 +389
- Partials 2194 2197 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bobozaur
requested review from
Patrik-Stas,
gmulhearn,
gmulhearn-anonyome and
mirgee
mirgee
reviewed
Sep 20, 2023
Patrik-Stas
suggested changes
Sep 20, 2023
Contributor
Patrik-Stas
left a comment
Patrik-Stas
left a comment
There was a problem hiding this comment.
lgtm, but left 1 comments
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
Signed-off-by: Bogdan Mircea <[email protected]>
* Fix lints from aries_vcx_core (#988) Signed-off-by: Bogdan Mircea <[email protected]>
Addressed lints and formatting in aries_vcx. Signed-off-by: Bogdan Mircea <[email protected]>
bobozaur
force-pushed
the
fix/lints_and_format
branch
from
b25d388 to
8f7cf87
Compare
Patrik-Stas
approved these changes
Sep 21, 2023
gmulhearn
approved these changes
Sep 21, 2023
mirgee
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more comprehensive formatting settings as well as tweaking
clippyandrustclints.The smaller crates have been adjusted and their lints fixed, but bigger ones like
aries-vcxorlibvcx-corewill be treated independently in different PRs since they are the main sources for conflicts.The declared lints are fairly opinionated, but it's a list that I've been building and use with pretty much all of my projects. They are obviously up for discussion and modifications.