[3.4, 3.3, 3.0] Backport of #30323 "x509: reject unauthorized stapled OCSP response signers"#30527
Open
esyr wants to merge 2 commits intoopenssl:openssl-3.4from
Open
[3.4, 3.3, 3.0] Backport of #30323 "x509: reject unauthorized stapled OCSP response signers"#30527esyr wants to merge 2 commits intoopenssl:openssl-3.4from
esyr wants to merge 2 commits intoopenssl:openssl-3.4from
Conversation
…k paths This is backport of 8a63091 "x509: remove OCSP_TRUSTOTHER from stapled response and issuer fallback paths" that includes only parts pertaining the openssl ocsp command. Original commit message: check_cert_ocsp_resp() verified stapled OCSP responses with OCSP_TRUSTOTHER while passing the peer-provided chain (ctx->chain), which allowed certificates from that chain to be treated as trusted OCSP responder signers. similarly, the ocsp CLI issuer fallback path unconditionally used OCSP_TRUSTOTHER, making certificates given via -issuer implicitly trusted regardless of verify_flags. remove OCSP_TRUSTOTHER from both paths so that responder authorization is validated against the trust store. Link: openssl#30323 References: 8a63091 "x509: remove OCSP_TRUSTOTHER from stapled response and issuer fallback paths" Fixes: c672406 "RT2206: Add -issuer flag to ocsp command"
This is a backport of commit 355ea2b "test: add regression tests for unauthorized OCSP response signers" that includes only parts pertaining the openssl ocsp command testing. The original commit message: extend test_tlsext_status_type() with a handshake that serves a leaf-signed stapled OCSP response and verifies the connection fails when X509_V_FLAG_OCSP_RESP_CHECK is enabled. generalize ocsp_server_cb_single() to use configurable signer cert/key instead of hardcoded paths so the same callback serves both authorized and unauthorized signer test cases. add a test_ocsp() subtest covering the -issuer CLI option with an untrusted issuer hint. Link: openssl#30323 References: 355ea2b "test: add regression tests for unauthorized OCSP response signers"
esyr
added
approval: review pending
DDvO
approved these changes
Mar 22, 2026
t8m
approved these changes
Mar 23, 2026
openssl-machine
added
approval: done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of [1] to
openssl-3.4,openssl-3.3, andopenssl-3.0that contains only parts pertainingopenssl ocspcommand fixes. It is different from [2] as it required conflict resolution intest/recipes/80-test_ocsp.tdue to absence of commit 421e8d7 "APPS/ocsp: fix case where reqin and outfile are the same" in those branches.[1] #30323
[2] #30526