Skip to content

Simplify ossl_namemap_name2num with ossl_namemap_name2num_n#30524

Open
jogme wants to merge 1 commit intoopenssl:masterfrom
jogme:ossl_namemap_name2num-merge
Open

Simplify ossl_namemap_name2num with ossl_namemap_name2num_n#30524
jogme wants to merge 1 commit intoopenssl:masterfrom
jogme:ossl_namemap_name2num-merge

Conversation

@jogme
Copy link
Contributor

@jogme jogme commented Mar 21, 2026

The two functions do the same; there is no reason to maintain duplicit
code.

Checklist
  • documentation is added or updated
  • tests are added or updated

@jogme jogme added approval: review pending This pull request needs review by a committer triaged: refactor The issue/pr requests/implements refactoring branch: master Applies to master branch branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 branch: 4.0 Applies to openssl-4.0 labels Mar 21, 2026
@jogme
Copy link
Contributor Author

jogme commented Mar 21, 2026

Not sure if we backport refactors; please correct the labels if not.

Just to note here, 3.0 and 3.3 has a different version still with the strndup.

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Mar 21, 2026
The two functions do the same; there is no reason to maintain duplicit
code.

Signed-off-by: Norbert Pocs <[email protected]>
@jogme jogme force-pushed the ossl_namemap_name2num-merge branch from dc88488 to d672088 Compare March 21, 2026 22:32
@jogme jogme requested a review from nhorman March 23, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: review pending This pull request needs review by a committer branch: master Applies to master branch branch: 3.5 Applies to openssl-3.5 branch: 3.6 Applies to openssl-3.6 branch: 4.0 Applies to openssl-4.0 severity: fips change The pull request changes FIPS provider sources triaged: refactor The issue/pr requests/implements refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants