Preserve serialized instance properties in Animate and SWFLite exports#44
Open
Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Open
Preserve serialized instance properties in Animate and SWFLite exports#44Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Tutez64 wants to merge 1 commit intoopenfl:masterfrom
Conversation
Member
Can you please add it by default when you open a PR? It would really be helpful! |
Author
|
Yes. I prepared a minimal reproduction project: SWFInstancePropertiesRepro.zip The included SWF is a tiny local test asset whose document class assigns dynamic properties on the root MovieClip. The repro exercises both AnimateLibrary and SWFLite export/runtime paths. Run:
Expected result with this patch (and also the EOF fix from #40):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This preserves serializable instance properties assigned by SWF scripts in both Animate and SWFLite export paths.
The exporter now extracts those properties from ABC data, stores them in the generated output, and restores them at runtime when symbols are instantiated.
It helps preprocessed exports retain data that would otherwise only be available when loading the original SWF directly.
Validated on both AnimateLibrary and SWFLite export/runtime paths, including SWFLite serialize/unserialize and root symbol instantiation.
I did not prepare a dedicated minimal reproduction project because the change is localized and was validated directly on affected assets. If needed, I can provide one.