libct: remove deprecated APIs#5141
Merged
kolyshkin merged 6 commits intoopencontainers:mainfrom Mar 4, 2026
Merged
Conversation
Member
Author
|
The only remaining deprecation marked with |
Member
|
All CI is failing with: |
Member
Author
|
Yeah I need to fix that, but I just realised that a better solution would be to just go ahead with @kolyshkin's suggestion and move |
Member
|
Makes sense. But IMHO I wouldn't block 1.5.0-rc.1 on that being merged. |
cyphar
force-pushed
the
remove-deprecated-apis
branch
from
0a002b2 to
c3eac91
Compare
Member
Author
|
I've split that bit out to a separate commit, let me move it to another PR... |
cyphar
force-pushed
the
remove-deprecated-apis
branch
from
c3eac91 to
8c6f52b
Compare
Ref: a412bd9 ("libct/utils: remove Deprecated functions") Signed-off-by: Aleksa Sarai <[email protected]>
These were all marked deprecated in commit a75076b ("Switch to opencontainers/cgroups") when we switched maintenance of our cgroup code to opencontainers/cgroups. Users have had ample time to switch to opencontainers/cgroups themselves, so we can finally remove this. Signed-off-by: Aleksa Sarai <[email protected]>
This was deprecated in commit e6a4870e4ac40 ("libct: better errors for
hooks"), and users have had ample time to migrate to Hooks.Run since.
Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
remove-deprecated-apis
branch
from
8c6f52b to
0bb11d8
Compare
These were inadvertently added to our exported APIs by commit
eeda7bdf80cca ("Add memory policy support"). We couldn't remove them
from runc 1.4.x, but we deprecated them in commit 3741f91
("libct/configs: mark MPOL_* constants as deprecated") and marked them
for removal in runc 1.5. Users should never have used these in the first
place.
Signed-off-by: Aleksa Sarai <[email protected]>
These were all marked deprecated in commit a75076b ("Switch to opencontainers/cgroups") when we switched maintenance of our cgroup code to opencontainers/cgroups. Users have had ample time to switch to opencontainers/cgroups themselves, so we can finally remove this. Note that the whole libcontainer/devices package will be moved to moby/sys in the near future, so this whole package will be marked deprecated soon. Signed-off-by: Aleksa Sarai <[email protected]>
This was a really ugly hack to try to reduce the impact of our original set of CVE-2019-5736 mitigations, but unfortunately had too many caveats to its use to ever be really useful. In addition, it was completely obsoleted by the migration to using an detached overlayfs mount in commit 515f09f ("dmz: use overlayfs to write-protect /proc/self/exe if possible"). Signed-off-by: Aleksa Sarai <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
cyphar
force-pushed
the
remove-deprecated-apis
branch
from
0bb11d8 to
e67725c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libcontainer/configs/cgroup_deprecated.golibcontainer/devices/device_deprecated.goconfigs.HooksList.RunHooksconfigs.MPOL_*Fixes #5120
Signed-off-by: Aleksa Sarai [email protected]