Support model-based (/engineless) completions in openai cli#20
Merged
Conversation
* Engineless completions in the SDK * Cosmetic improvements to fine tuning CLI * Remove done TODO * Raise error if neither engine nor model provided * Undocument the `timeout` parameter on completions, because it doesn't do anything and causes user confusion. * Move things around * Update message * Some day we should care about versions
emorikawa
approved these changes
Jun 17, 2021
| @@ -1 +1 @@ | |||
| VERSION = "0.7.0" | |||
| VERSION = "0.7.1" | |||
Contributor
There was a problem hiding this comment.
Even though we're still a 0.x, I tend to prefer using minor, instead of patch, as the version bump for new features. So 0.8.0
pull Bot
referenced
this pull request
in mcx/openai-python
Oct 10, 2021
* CLI cleanup * Also support uploading files as a convenience to the user * Events in the CLI (#23) * Events in the CLI * Update message about ctrl-c * Version * Forgot to use the api_base arg (#20) * Forgot to use the api_base arg * Bump version * newline Co-authored-by: hallacy <[email protected]>
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
* CLI cleanup * Also support uploading files as a convenience to the user * Events in the CLI (openai#23) * Events in the CLI * Update message about ctrl-c * Version * Forgot to use the api_base arg (openai#20) * Forgot to use the api_base arg * Bump version * newline Co-authored-by: hallacy <[email protected]>
cgayapr
pushed a commit
to cgayapr/openai-python
that referenced
this pull request
Dec 14, 2024
* Support model-based (/engineless) completions in openai cli (openai#31) * Engineless completions in the SDK * Cosmetic improvements to fine tuning CLI * Remove done TODO * Raise error if neither engine nor model provided * Undocument the `timeout` parameter on completions, because it doesn't do anything and causes user confusion. * Move things around * Update message * Some day we should care about versions * Minor version bump
safa0
pushed a commit
to safa0/openai-agents-python
that referenced
this pull request
Apr 27, 2025
Add callout on compatibility w other providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does several things:
/v1/completionsis now a thing. If theengineparameter is not supplied, we make requests to that path. Otherwise, ifengineis provided, requests are made to/v1/engine/<ENGINE>/completions. We expect most users to still useengineright now.)