Remove unnecessary type checks since PyFloat_AsDouble() will convert the value

anthony-tuininga · anthony-tuininga · commit cf19bc7f74af · 2017-12-15T08:49:27.000-07:00
to floating point if possible anyway, and if not, will raise an appropriate
exception.
diff --git a/src/NumberVar.c b/src/NumberVar.c
@@ -198,14 +198,6 @@ static int NumberVar_SetValueDecimal(udt_Variable *var, uint32_t pos,
 static int NumberVar_SetValueFloat(udt_Variable *var, uint32_t pos,
         dpiData *data, PyObject *value)
 {
-    if (!PyFloat_Check(value) &&
-#if PY_MAJOR_VERSION < 3
-            !PyInt_Check(value) &&
-#endif
-            !PyLong_Check(value)) {
-        PyErr_SetString(PyExc_TypeError, "expecting float");
-        return -1;
-    }
     data->value.asDouble = PyFloat_AsDouble(value);
     if (PyErr_Occurred())
         return -1;
