Skip to content

Bring omniauth-github up-to-date#61

Merged
tmilewski merged 5 commits into
omniauth:masterfrom
tmilewski:modernize
Feb 1, 2017
Merged

Bring omniauth-github up-to-date#61
tmilewski merged 5 commits into
omniauth:masterfrom
tmilewski:modernize

Conversation

@tmilewski

@tmilewski tmilewski commented Aug 7, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

@mbleigh - Please consider this PR and update RubyGems accordingly. The current version is out-of-date by over two years and contains security vulnerabilities. Thanks!

This PR does the following:

Security Updates

  • Uses https for the RubyGems URL to pass bundler audit

Dependencies

  • Bumps omniauth to ~>1.3.2
  • Bumps omniauth-oauth2 to ~> 1.4.0
  • Bumps rspec to ~> 3.5

Specs

  • Updates specs to RSpec 3+ syntax

Housekeeping

  • Ensure similar code formatting in specs
  • Bump gem version to 1.2.0

Closes #59
Closes #52
Closes #57

@tmilewski

tmilewski commented Aug 7, 2016

Copy link
Copy Markdown
Member Author

Updates per @yaodong and @boutil's issues.

@tmilewski tmilewski mentioned this pull request Aug 7, 2016
Merged
@tmilewski

tmilewski commented Aug 28, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

Ping @mbleigh & @intridea-shared

@mbleigh

mbleigh commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

I don't actively maintain this gem anymore. @sferik is this one of the many
you're on?

On Sun, Aug 28, 2016, 3:00 PM Tom Milewski [email protected] wrote:

Ping @mbleigh https://github.com/mbleigh

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#61 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAD_nFid6tC5XEg5hEXv7DYFYbnFuiBks5qkgTzgaJpZM4JebJ1
.

@tmilewski

tmilewski commented Aug 29, 2016

Copy link
Copy Markdown
Member Author

@mbleigh All good, I just want to make sure it gets updated so that there's no longer any security concerns through out-of-date dependencies.

As time permits, I'm happy to take over some maintenance responsibilities as well.

@tmilewski

tmilewski commented Sep 9, 2016

Copy link
Copy Markdown
Member Author

Ping @sferik, are you an owner?

@joegoggins

joegoggins commented Jan 31, 2017

Copy link
Copy Markdown

No response in ~4 months would indicate that @sferik is not a maintainer.

@mbleigh , any chance you could widen the maintainer pool to include @tmilewski so this could get merged and released to rubygems?

@mbleigh

mbleigh commented Jan 31, 2017

Copy link
Copy Markdown
Contributor

@tmilewski you've been added.

@sferik

sferik commented Feb 1, 2017

Copy link
Copy Markdown

Sorry, just seeing this now…

@tmilewski Welcome to the team!

@tmilewski

tmilewski commented Feb 1, 2017

Copy link
Copy Markdown
Member Author

@mbleigh @sferik Thanks guys! Going through this now!

@tmilewski tmilewski merged commit 443a6b3 into omniauth:master Feb 1, 2017
@tmilewski

tmilewski commented Feb 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

@mbleigh:
Mind adding me to RubyGems so that I may push this out to the world? Thanks!
gem owner omniauth-github --add [email protected]

All:
In the meantime, this will work...
gem 'omniauth-github', git: 'https://github.com/intridea/omniauth-github.git', tag: '1.2.0'

Excited!

@mbleigh

mbleigh commented Feb 1, 2017

Copy link
Copy Markdown
Contributor

@tmilewski the power is yours!

Captain Planet

@tmilewski

tmilewski commented Feb 1, 2017

Copy link
Copy Markdown
Member Author

@mbleigh Perfect, thank you! It's now live!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmilewski @mbleigh @joegoggins @sferik