Skip to content

Commit e1170bf

Browse files
committed
cqle: tuple test tweaks
(some are still broken)
1 parent 6560bfc commit e1170bf

1 file changed

Lines changed: 24 additions & 25 deletions

File tree

tests/integration/cqlengine/columns/test_container_columns.py

Lines changed: 24 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -560,37 +560,36 @@ def tearDownClass(cls):
560560

561561
def test_initial(self):
562562
tmp = TestTupleModel.create()
563-
tmp.int_tuple = tmp.int_tuple + (1, 2, 3)
563+
tmp.int_tuple = (1, 2, 3)
564564

565565
def test_initial_retrieve(self):
566566
tmp = TestTupleModel.create()
567567
tmp2 = tmp.get(partition=tmp.partition)
568-
tmp2.int_tuple = tmp2.int_tuple + (1, 2, 3)
568+
tmp2.int_tuple = (1, 2, 3)
569569

570570
def test_io_success(self):
571571
""" Tests that a basic usage works as expected """
572572
m1 = TestTupleModel.create(int_tuple=(1, 2, 3, 5, 6), text_tuple=('kai', 'andreas'), mixed_tuple=('first', 2, 'Third'))
573573
m2 = TestTupleModel.get(partition=m1.partition)
574574

575-
assert isinstance(m2.int_tuple, tuple)
576-
assert isinstance(m2.text_tuple, tuple)
577-
assert isinstance(m2.mixed_tuple, tuple)
575+
self.assertIsInstance(m2.int_tuple, tuple)
576+
self.assertIsInstance(m2.text_tuple, tuple)
577+
self.assertIsInstance(m2.mixed_tuple, tuple)
578578

579+
self.assertEqual(len(m2.int_tuple), 3)
580+
self.assertEqual(len(m2.text_tuple), 2)
581+
self.assertEqual(len(m2.mixed_tuple), 3)
579582

580-
assert len(m2.int_tuple) == 3
581-
assert len(m2.text_tuple) == 2
582-
assert len(m2.mixed_tuple) == 3
583+
self.assertEqual(m2.int_tuple[0], 1)
584+
self.assertEqual(m2.int_tuple[1], 2)
585+
self.assertEqual(m2.int_tuple[2], 3)
583586

584-
assert m2.int_tuple[0] == 1
585-
assert m2.int_tuple[1] == 2
586-
assert m2.int_tuple[2] == 3
587+
self.assertEqual(m2.text_tuple[0], 'kai')
588+
self.assertEqual(m2.text_tuple[1], 'andreas')
587589

588-
assert m2.text_tuple[0] == 'kai'
589-
assert m2.text_tuple[1] == 'andreas'
590-
591-
assert m2.mixed_tuple[0] == 'first'
592-
assert m2.mixed_tuple[1] == 2
593-
assert m2.mixed_tuple[2] == 'Third'
590+
self.assertEqual(m2.mixed_tuple[0], 'first')
591+
self.assertEqual(m2.mixed_tuple[1], 2)
592+
self.assertEqual(m2.mixed_tuple[2], 'Third')
594593

595594
def test_type_validation(self):
596595
"""
@@ -606,9 +605,9 @@ def test_instantiation_with_column_class(self):
606605
and that the class is instantiated in the constructor
607606
"""
608607
mixed_tuple = columns.Tuple(columns.Text, columns.Integer, columns.Text, required=False)
609-
assert isinstance(mixed_tuple.types[0], columns.Text)
610-
assert isinstance(mixed_tuple.types[1], columns.Integer)
611-
assert isinstance(mixed_tuple.types[2], columns.Text)
608+
self.assertIsInstance(mixed_tuple.types[0], columns.Text)
609+
self.assertIsInstance(mixed_tuple.types[1], columns.Integer)
610+
self.assertIsInstance(mixed_tuple.types[2], columns.Text)
612611
self.assertEqual(len(mixed_tuple.types), 3)
613612

614613
def test_default_empty_container_saving(self):
@@ -645,9 +644,9 @@ def test_to_python(self):
645644
column = columns.Tuple(JsonTestColumn)
646645
val = (1, 2, 3)
647646
db_val = column.to_database(val)
648-
assert db_val == [json.dumps(v) for v in val]
647+
self.assertEqual(db_val, tuple(json.dumps(v) for v in val))
649648
py_val = column.to_python(db_val)
650-
assert py_val == val
649+
self.assertEqual(py_val, val)
651650

652651
def test_update_from_non_empty_to_empty(self):
653652
# Can up date a touple raises a Runtime Error
@@ -657,7 +656,7 @@ def test_update_from_non_empty_to_empty(self):
657656
tmp.update()
658657

659658
tmp = TestTupleModel.get(partition=pkey)
660-
self.assertEqual(tmp.int_tuple, (1, 3))
659+
self.assertEqual(tmp.int_tuple, (1, 3, None))
661660

662661
def test_insert_none(self):
663662
pkey = uuid4()
@@ -671,12 +670,12 @@ def test_blind_tuple_updates_from_none(self):
671670
m.save()
672671

673672
m2 = TestTupleModel.get(partition=m.partition)
674-
assert m2.int_tuple == expected
673+
self.assertEqual(m2.int_tuple, expected)
675674

676675
TestTupleModel.objects(partition=m.partition).update(int_tuple=None)
677676

678677
m3 = TestTupleModel.get(partition=m.partition)
679-
assert m3.int_tuple == ()
678+
self.assertEqual(m3.int_tuple, None)
680679

681680

682681
class TestTupleModelVeryLarge(Model):

0 commit comments

Comments
 (0)