feature: add aliases for inline tests #11109

Alizter · 2024-11-10T16:20:16Z

For a given library with inlines tests, we add an alias with the name of the library for running those tests prefixed by inline-test-.

Further work on separating out the partition actions would allow us to have an alias for each partition.

For now, this will allow us to run inline tests with the runtest command. Further work on that will follow this PR.

This addresses part of #10239 the remaining part would be to add an alias to the (test) stanza.

changelog
documentation

src/dune_rules/inline_tests.ml

This bug was noticed when working on ocaml#11109. The issue is that the cram rules create two copies of the anonymous cram action, however since the alias names are different (runtest vs cram test name) this ends up with having two different digests. This means that when building `@runtest` and `@mycram` we end up running the cram test `mycram.t` twice. This test demonstrates this behaviour. Signed-off-by: Ali Caglayan <[email protected]>

Alizter · 2025-03-22T15:23:50Z

@emillon I've updated the documentation but it could be better. Any ideas on improving it?

This bug was noticed when working on ocaml#11109. The issue is that the cram rules create two copies of the anonymous cram action, however since the alias names are different (runtest vs cram test name) this ends up with having two different digests. This means that when building `@runtest` and `@mycram` we end up running the cram test `mycram.t` twice. This test demonstrates this behaviour. Signed-off-by: Ali Caglayan <[email protected]>

* test: cram tests are run twice when both aliases are built This bug was noticed when working on #11109. The issue is that the cram rules create two copies of the anonymous cram action, however since the alias names are different (runtest vs cram test name) this ends up with having two different digests. This means that when building `@runtest` and `@mycram` we end up running the cram test `mycram.t` twice. This test demonstrates this behaviour. Signed-off-by: Ali Caglayan <[email protected]> * fix: double run of cram tests We fix an issue where cram tests were being run twice due to anonymous actions being created for each alias associated to a given cram test. We fix this by distinguishing one of the aliases and only creating the action for that while allowing the other aliases to depend on that alias. This required changing the cram specification slightly, but has simplified the rule generation somewhat. Signed-off-by: Ali Caglayan <[email protected]> --------- Signed-off-by: Ali Caglayan <[email protected]>

* test: cram tests are run twice when both aliases are built This bug was noticed when working on ocaml#11109. The issue is that the cram rules create two copies of the anonymous cram action, however since the alias names are different (runtest vs cram test name) this ends up with having two different digests. This means that when building `@runtest` and `@mycram` we end up running the cram test `mycram.t` twice. This test demonstrates this behaviour. Signed-off-by: Ali Caglayan <[email protected]> * fix: double run of cram tests We fix an issue where cram tests were being run twice due to anonymous actions being created for each alias associated to a given cram test. We fix this by distinguishing one of the aliases and only creating the action for that while allowing the other aliases to depend on that alias. This required changing the cram specification slightly, but has simplified the rule generation somewhat. Signed-off-by: Ali Caglayan <[email protected]> --------- Signed-off-by: Ali Caglayan <[email protected]>

rgrinberg · 2025-04-23T16:12:08Z

How about we add a lib: prefix to such aliases? At the moment, this PR has the potential for breakage if the user has their own stanzas named after a library. There is no potential for free tab completion for files, so it seems like a prefix costs us nothing.

Alizter · 2025-04-23T16:49:31Z

@rgrinberg I'm okay with the idea, but isn't it a bit confusing to run a test as @lib:foo? Wouldn't it be yet anther thing to remember when writing a command?

Alizter · 2025-04-23T16:58:32Z

I've pushed a commit changing it to lib: but I haven't squashed it yet while we still think about it. I guess if it is documented well and we write a clear tutorial about it, it should be no issue.

Alizter · 2025-04-23T17:04:58Z

Ah, we are getting complaints from Dune_util that lib:name is an invalid alias name.

The validation that we do in Dune_util.Alias_name is a bit bogus tbh. I ran into similar issues when trying to add cram.t aliases. This kind of check:

let of_string_opt_loose s = Option.some_if (Filename.basename s = s) s

Is the culprit. Do you think its time to get rid of it and put something more sophisticated with a clear specification of what is valid/invalid?

rgrinberg · 2025-04-24T19:47:24Z

Forbidding : and most other characters doesn't really make sense. As long as the alias name cannot be interpreted as a path that escaped the current directory.

rgrinberg · 2025-04-24T19:48:57Z

@rgrinberg I'm okay with the idea, but isn't it a bit confusing to run a test as @lib:foo? Wouldn't it be yet anther thing to remember when writing a command?

I don't see how you some rather hard to debug cycles without this. You can reproduce this by:

Having a library foo with inline tests
Creating a rule that generates a source file for foo
Making the rule depend on @foo

Alizter · 2025-04-25T09:27:59Z

OK so the problem we have here is that : is considered a path separator only on windows. Technically a user can write dune build @C:/foo/bar/myproject/myalias with how we parse aliases. So the : does play a special role during path parsing. We can't have it in alias names or else we would allow : in filenames at least on windows.

Alizter · 2025-04-25T09:29:24Z

I'm going to mark this PR as draft while I think of a way to validate alias names and keep them flexible.

For a given library with inlines tests, we add an alias with the name of the library for running those tests prefixed with `runtest-`. Further work on separating out the partition actions would allow us to have an alias for each partition. For now, this allows us to run inline tests with the runtest command. Signed-off-by: Ali Caglayan <[email protected]>

* test: cram tests are run twice when both aliases are built This bug was noticed when working on ocaml#11109. The issue is that the cram rules create two copies of the anonymous cram action, however since the alias names are different (runtest vs cram test name) this ends up with having two different digests. This means that when building `@runtest` and `@mycram` we end up running the cram test `mycram.t` twice. This test demonstrates this behaviour. Signed-off-by: Ali Caglayan <[email protected]> * fix: double run of cram tests We fix an issue where cram tests were being run twice due to anonymous actions being created for each alias associated to a given cram test. We fix this by distinguishing one of the aliases and only creating the action for that while allowing the other aliases to depend on that alias. This required changing the cram specification slightly, but has simplified the rule generation somewhat. Signed-off-by: Ali Caglayan <[email protected]> --------- Signed-off-by: Ali Caglayan <[email protected]>

For a given library with inlines tests, we add an alias with the name of the library for running those tests prefixed with `runtest-`. Further work on separating out the partition actions would allow us to have an alias for each partition. For now, this allows us to run inline tests with the runtest command. Signed-off-by: Ali Caglayan <[email protected]>

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@` and `@@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11836, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

@rgrinberg

CHANGES: ### Fixed - Stop re-running cram tests after promotion when it's not necessary (ocaml/dune#11994, @rgrinberg) - fix: `$ dune subst` should not fail when adding the version field in opam files (ocaml/dune#11801, fixes ocaml/dune#11045, @btjorge) - Kill all processes in the process group after the main process has terminated; in particular this avoids background processes in cram tests to stick around after the test finished (ocaml/dune#11841, fixes ocaml/dune#11820, @Alizter, @Leonidas-from-XIV) ### Added - `(tests)` stanzas now generate aliases with the test name. To run `(test (name a))` you can do `dune build @runtest-a`. (ocaml/dune#11558, grants part of ocaml/dune#10239, @Alizter) - Inline test libraries now produce aliases `runtest-name_of_lib` allowing users to run specific inline tests as `dune build @runtest-name_of_lib`. (ocaml/dune#11109, partially fixes ocaml/dune#10239, @Alizter) - feature: `$ dune subst` use version from `dune-project` when no version control repository has been detected (ocaml/dune#11801, @btjorge) - Allow `dune exec` to run concurrently with another instance of dune in watch mode (ocaml/dune#11840, @gridbugs) - Introduce `%{os}`, `%{os_version}`, `%{os_distribution}`, and `%{os_family}` percent forms. These have the same values as their opam counterparts. (ocaml/dune#11863, @rgrinberg) - Introduce option `(implicit_transitive_deps false-if-hidden-includes-supported)` that is equivalent to `(implicit_transitive_deps false)` when `-H` is supported by the compiler (OCaml >= 5.2) and equivalent to `(implicit_transitive_deps true)` otherwise. (ocaml/dune#11866, fixes ocaml/dune#11212, @nojb) - Add `dune describe location` for printing the path to the executable that would be run (ocaml/dune#11905, @gridbugs) - `dune runtest` can now understand absolute paths as well as run tests in specific build contexts (ocaml/dune#11936, @Alizter). - Added 'empty' alias which contains no targets. (ocaml/dune#11556 ocaml/dune#11952 ocaml/dune#11955 ocaml/dune#11956, grants ocaml/dune#4161, @Alizter and @rgrinberg) - Allow `dune promote` to properly run while a watch mode server is running (ocaml/dune#12010, @ElectreAAS) - Add `--alias` and `--alias-rec` flags as an alternative to the `@@` and `@` syntax in the command line (ocaml/dune#12043, fixes ocaml/dune#5775, @rgrinberg) - Added a `(timeout <float>)` field to the `(cram)` stanza to specify per-test time limits. Tests exceeding the timeout are terminated with an error. (ocaml/dune#12041, @Alizter) ### Changed - Format long lists in s-expressions to fill the line instead of formatting them in a vertical way (ocaml/dune#10892, fixes ocaml/dune#10860, @nojb) - Switch from MD5 to BLAKE3 for digesting targets and rules. BLAKE3 is both more performant and difficult to break than MD5 (ocaml/dune#11735, @rgrinberg, @Alizter) - Print a warning when `dune build` runs over RPC (ocaml/dune#11833, @gridbugs) - Stop emitting empty module group wrapper `.js` file in `melange.emit` (ocaml/dune#11987, fixes ocaml/dune#11986, @anmonteiro)

Alizter requested a review from rgrinberg November 10, 2024 16:20

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from b5d5d4f to 0e1c216 Compare November 10, 2024 16:24

hhugo reviewed Nov 10, 2024

View reviewed changes

src/dune_rules/inline_tests.ml Outdated Show resolved Hide resolved

Alizter marked this pull request as draft November 20, 2024 21:59

hhugo mentioned this pull request Jan 28, 2025

It should be possible to run tests from a specific module with runtest #870

Closed

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from 0e1c216 to 9842240 Compare March 19, 2025 14:39

Alizter mentioned this pull request Mar 19, 2025

test: cram tests are run twice when both aliases are built #11547

Merged

1 task

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch 2 times, most recently from 0a26c59 to 8a845fe Compare March 22, 2025 15:11

Alizter marked this pull request as ready for review March 22, 2025 15:11

Alizter requested a review from hhugo March 22, 2025 15:12

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from 8a845fe to 6401184 Compare March 22, 2025 15:22

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from 6401184 to ef3524f Compare March 22, 2025 15:35

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from ef3524f to ff7d3da Compare March 23, 2025 12:17

Alizter mentioned this pull request Mar 23, 2025

feature: tests stanzas produce aliases #11558

Merged

3 tasks

Alizter requested review from rgrinberg and removed request for rgrinberg April 8, 2025 13:23

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from eb01971 to 9ab2826 Compare April 23, 2025 16:57

Alizter marked this pull request as draft April 25, 2025 09:29

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from 9ab2826 to 9c32c77 Compare May 7, 2025 21:12

Alizter marked this pull request as ready for review May 7, 2025 21:20

Alizter force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from 9c32c77 to b38d581 Compare May 8, 2025 12:57

rgrinberg force-pushed the ps/rr/feature__add_aliases_for_inline_tests branch from b38d581 to cf522f1 Compare July 5, 2025 15:41

rgrinberg merged commit 12daf40 into ocaml:main Jul 5, 2025
21 of 25 checks passed

Alizter deleted the ps/rr/feature__add_aliases_for_inline_tests branch July 5, 2025 21:13

Alizter mentioned this pull request Jul 7, 2025

Automatically add aliases for expect tests #10239

Closed

maiste mentioned this pull request Jul 28, 2025

[new release] dune (15 packages) (3.20.0~alpha0) ocaml/opam-repository#28267

Closed

maiste mentioned this pull request Jul 30, 2025

[new release] dune (15 packages) (3.20.0~alpha1) ocaml/opam-repository#28276

Closed

maiste mentioned this pull request Aug 5, 2025

[new release] dune (15 packages) (3.20.0~alpha2) ocaml/opam-repository#28298

Closed

maiste mentioned this pull request Aug 6, 2025

[new release] dune (15 packages) (3.20.0~alpha3) ocaml/opam-repository#28302

Closed

maiste mentioned this pull request Aug 12, 2025

[new release] dune (15 packages) (3.20.0~alpha4) ocaml/opam-repository#28333

Closed

maiste mentioned this pull request Aug 19, 2025

[new release] dune (15 packages) (3.20.0) ocaml/opam-repository#28357

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feature: add aliases for inline tests #11109

feature: add aliases for inline tests #11109

Uh oh!

Alizter commented Nov 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

Alizter commented Mar 22, 2025

Uh oh!

rgrinberg commented Apr 23, 2025

Uh oh!

Alizter commented Apr 23, 2025 •

edited

Loading

Uh oh!

Alizter commented Apr 23, 2025

Uh oh!

Alizter commented Apr 23, 2025

Uh oh!

rgrinberg commented Apr 24, 2025

Uh oh!

rgrinberg commented Apr 24, 2025

Uh oh!

Alizter commented Apr 25, 2025

Uh oh!

Alizter commented Apr 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feature: add aliases for inline tests #11109

feature: add aliases for inline tests #11109

Uh oh!

Conversation

Alizter commented Nov 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Alizter commented Mar 22, 2025

Uh oh!

rgrinberg commented Apr 23, 2025

Uh oh!

Alizter commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alizter commented Apr 23, 2025

Uh oh!

Alizter commented Apr 23, 2025

Uh oh!

rgrinberg commented Apr 24, 2025

Uh oh!

rgrinberg commented Apr 24, 2025

Uh oh!

Alizter commented Apr 25, 2025

Uh oh!

Alizter commented Apr 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alizter commented Nov 10, 2024 •

edited

Loading

Alizter commented Apr 23, 2025 •

edited

Loading