Skip to content

Find usages add #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xzescha wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Find usages add #68

xzescha wants to merge 45 commits into from
+1,470 −121

Conversation

@xzescha
Copy link
Contributor

@xzescha xzescha commented May 13, 2025

Added find usages add-on implementation. It's not fully refactored yet, but till tomorrow it'll be fully ready to merge!

@0crat
Copy link

0crat commented May 14, 2025

@xzescha Hey there! 👋 I noticed your branch name "find-usages-add" doesn't quite follow our naming convention. According to our policy, this means a -12 point penalty. For future reference, it's best to name branches after the ticket number you're working on, like "67" in this case. This helps everyone stay organized and on the same page. Your current balance is now -12. Let's aim for better naming next time to avoid those penalties!

@xzescha
Copy link
Contributor Author

xzescha commented May 17, 2025

@yegor256 could you please review this and my other PR. Hope so, they're valid and ready to merge!

@yegor256
Copy link
Member

yegor256 commented May 18, 2025

@xzescha I see most build jobs failing. We can't merge now, see: https://www.yegor256.com/2025/04/19/dont-merge-into-broken-master.html

xzescha added 16 commits May 30, 2025 22:02
@xzescha
first try to fix pipelines
eef027b
@xzescha
another try to fix pipelines
525346a
@xzescha
another another try to fix pipelines
ada7fb2
@xzescha
another another another try to fix pipelines
a93ecb2
@xzescha
another another another another try to fix pipelines
8a90372
@xzescha
try to fix pipelines reverted changes to initial state in March
e8f3a7b
@xzescha
try to fix pipelines reverted changes to initial state in March
17a1e9d
@xzescha
try to fix pipelines reverted changes to initial state in March remov…
3a1d4e5 
…ed outdated versions of IDEA, to try with only new one
@xzescha
try to fix pipelines reverted changes to initial state in March remov…
f611915 
…ed outdated versions of IDEA, to try with only new one. Try with different build.gradle
@xzescha
Try to avoid error running qulice
a8678b6
@xzescha
Try to avoid error running qulice pt.2
877f747
@xzescha
Try to avoid error running qulice pt.2
e99b558
@xzescha
Try to avoid error running qulice pt.2
cb50a39
@xzescha
Try to avoid error running qulice pt.4
7d04693
@xzescha
Try to avoid error running qulice pt.5
66fe380
@xzescha
Try to avoid error running qulice pt.6
d47d1b2
@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.91304% with 47 lines in your changes missing coverage. Please review.

Project coverage is 35.10%. Comparing base (5a07317) to head (c18c372).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/org/eolang/jetbrains/EoCompileAction.java 27.50% 28 Missing and 1 partial ⚠️
...ava/org/eolang/jetbrains/EoFindUsagesProvider.java 0.00% 17 Missing ⚠️
.../org/eolang/jetbrains/EoCompletionContributor.java 97.14% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
- Coverage     35.60%   35.10%   -0.50%     
+ Complexity       25       19       -6     
============================================
  Files            13       12       -1     
  Lines           191      188       -3     
  Branches          5       17      +12     
============================================
- Hits             68       66       -2     
  Misses          119      119              
+ Partials          4        3       -1
Flag Coverage Δ
junit 35.10% <48.91%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xzescha added 18 commits May 31, 2025 00:42
@xzescha
Try to avoid pipelines failure
9b0fb5c
@xzescha
Try to avoid pipelines failure
1e3de95
@xzescha
Try to avoid pipelines failure
90737ce
@xzescha
Try to avoid pipelines failure another try on another
0d784d0
@xzescha
Try to avoid pipelines failure another try on another
59e672d
@xzescha
Try to avoid pipelines failure another try on another
2febe4f
@xzescha
Try to avoid pipelines failure another try on another
55817b5
@xzescha
Try to avoid pipelines failure another try on another and another
efe4f76
@xzescha
Try to avoid pipelines failure another try on another and another and…
d765a11 
… another
@xzescha
Try to avoid pipelines failure another try on another and another and…
6af9423 
… another and another
@xzescha
Added new test
7a6aa16
@xzescha
Added new test and excluded auto-generated files
967583a
@xzescha
Added new test for performUnsafe in EoCompileAction
fa50289
@xzescha
Added new test for performUnsafe in EoCompileAction, extended buildGo…
d4d6048 
…als test
@xzescha
Added new tests for parsing
32eb695
@xzescha
Skipped qulice bug in EoParsingTest.java
cf31ea6
@xzescha
Added tests for EoCompletionContributor.java. Also removed classes th…
04e181d 
…at directly affects UI, that can't be tested as Unit-tests
@xzescha
Avoided qulice bug in EoCompletionContributorTest.java
c18c372
@xzescha
Copy link
Contributor Author

xzescha commented Jun 1, 2025

@yegor256, Done! I've fixed pipelines, added few tests for new funtionality.

@xzescha xzescha mentioned this pull request Jun 1, 2025
Open
@yegor256
Copy link
Member

yegor256 commented Jun 1, 2025

@volodya-lombrozo can you please review this?

@yegor256 yegor256 requested a review from volodya-lombrozo June 1, 2025 03:51
volodya-lombrozo
volodya-lombrozo suggested changes Jun 4, 2025
View reviewed changes
Copy link
Member

@volodya-lombrozo volodya-lombrozo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xzescha Great thanks for the PR. There are lots of valuable changes.

However, I highly recommend you reading Helping others review your changes. Pay attention to:

  1. Write small pull requests
  2. Provide context and guidance

For example, it's hard to understand what you are trying to solve in this PR. Could you provide a link to the issue, please? Also, a detailed explanation would also greatly help here.

Another important aspect is the PR size. The PR is too big and it seems we are trying to solve many problems at once. Can we split this PR on a few small PRs? It would be better if they were 100~300 lines length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@volodya-lombrozo volodya-lombrozo volodya-lombrozo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xzescha @0crat @yegor256 @volodya-lombrozo