Skip to content

Commit d2284e3

Browse files
jasonLasterjbhoosreddy
authored andcommitted
Show source tab for paused evals
1 parent b519080 commit d2284e3

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/components/SourceTabs.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const {
77
getSelectedSource, getSourceTabs,
88
getFileSearchState, getSourceByURL
99
} = require("../selectors");
10-
const { getFilename, getRawSourceURL, isPretty } = require("../utils/source");
10+
const { getFilename, isPretty } = require("../utils/source");
1111
const { isEnabled } = require("devtools-config");
1212
const classnames = require("classnames");
1313
const actions = require("../actions");
@@ -17,7 +17,6 @@ const Svg = require("./shared/Svg");
1717
const Dropdown = React.createFactory(require("./Dropdown"));
1818
const { showMenu, buildMenu } = require("../utils/menu");
1919
const { debounce } = require("lodash");
20-
const { getURL } = require("../utils/sources-tree.js");
2120
const { formatKeyShortcut } = require("../utils/text");
2221
require("./SourceTabs.css");
2322
require("./Dropdown.css");
@@ -257,7 +256,7 @@ const SourceTabs = React.createClass({
257256

258257
renderTab(source) {
259258
const { selectedSource, selectSource, closeTab } = this.props;
260-
const filename = getRawSourceURL(getURL(source.get("url")).filename);
259+
const filename = getFilename(source.toJS());
261260
const active = source.get("id") == selectedSource.get("id");
262261
const isPrettyCode = isPretty({ url: source.get("url") });
263262

@@ -275,7 +274,7 @@ const SourceTabs = React.createClass({
275274
key: source.get("id"),
276275
onClick: () => selectSource(source.get("id")),
277276
onContextMenu: (e) => this.onTabContextMenu(e, source.get("id")),
278-
title: getRawSourceURL(source.get("url"))
277+
title: getFilename(source.toJS())
279278
},
280279
isPrettyCode ? Svg("prettyPrint") : null,
281280
dom.div({ className: "filename" }, filename),

src/utils/source.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,14 @@ function getRawSourceURL(url: string): string {
7575
* @static
7676
*/
7777
function getFilename(source: Source) {
78-
const { url, id } = source;
78+
let { url, id } = source;
7979
if (!url) {
8080
const sourceId = id.split("/")[1];
8181
return `SOURCE${sourceId}`;
8282
}
8383

84-
const name = basename(source.url || "") || "(index)";
84+
url = getRawSourceURL(url || "");
85+
const name = basename(url) || "(index)";
8586
return endTruncateStr(name, 50);
8687
}
8788

0 commit comments

Comments
 (0)