Fix low performance of mmap rwmode #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
to fix issue: #551 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes low performance issues in the mmap read-write mode by implementing a singleton pattern for MMapRWManager and introducing block-based memory mapping. The key performance improvement comes from avoiding the creation of new mmap instances for each read/write operation.
- Implements singleton pattern for MMapRWManager instances per data file
- Introduces block-based memory mapping with LRU caching for better memory management
- Adds comprehensive test coverage for edge cases and cross-block operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| rwmanger_mmap.go | Core implementation of singleton MMapRWManager with block-based mapping and LRU caching |
| rwmanager_mmap_test.go | Updated and expanded tests for the new MMapRWManager implementation |
| file_manager.go | Simplified MMapRWManager creation to use the new singleton pattern |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
Author
|
@bigboss2063 all comments resolved. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fix:
After fix:
fix design:
before fix, for each get / write operation will generate a new mmap instance, it will make operation very slow.
after that, we make mmapRWManager as a singleton for each data file. And for each mmapRWManager, I split data file as many part of mmap.