feat : add PutIfExists(SETEX) and PutIfNotExists(SETNX) APIs #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigboss2063
reviewed
Dec 8, 2023
ksankeerth
force-pushed
the
dev-517-setnx-and-setex
branch
from
1697f24 to
d4e06f4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
- Coverage 70.96% 70.74% -0.23%
==========================================
Files 36 36
Lines 5177 5216 +39
==========================================
+ Hits 3674 3690 +16
- Misses 1134 1151 +17
- Partials 369 375 +6 ☔ View full report in Codecov by Sentry. |
bigboss2063
approved these changes
Dec 11, 2023
Member
bigboss2063
left a comment
bigboss2063
left a comment
There was a problem hiding this comment.
LGTM! Thanks to your elegant code.
Member
|
Welcome to do more things in nutsdb 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds suggest new APIs (SETEX and SETNX) in #517
Note: #526 this bug has to be fixed before merging this.