pref: reduce unnecessary fields in Record and save memory #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
==========================================
+ Coverage 71.27% 71.46% +0.19%
==========================================
Files 35 35
Lines 5047 5032 -15
==========================================
- Hits 3597 3596 -1
+ Misses 1092 1080 -12
+ Partials 358 356 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Record was used as a memory index item, which had many unnecessary fields placed in memory #505 . This time, all of them are removed. One record can save 22 bytes of memory usage!
At the same time, the interface of the BTree index type is modified. It no longer returns Entry, but directly returns Value of byte array type.
It can increase the ease of use. If users need to use other fields in Entry, we can provide an interface.