Skip to content

Conversation

@G-XD
Copy link
Contributor

@G-XD G-XD commented Aug 22, 2023

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #445 (a85a217) into master (0eae1bc) will decrease coverage by 0.71%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
- Coverage   66.97%   66.26%   -0.71%     
==========================================
  Files          34       34              
  Lines        5910     5902       -8     
==========================================
- Hits         3958     3911      -47     
- Misses       1606     1632      +26     
- Partials      346      359      +13     

see 2 files with indirect coverage changes

@bigboss2063
Copy link
Member

TestTx_SRem2 中 83-88 是否也用封装好的 txSAreMembers 比较好?

@bigboss2063 bigboss2063 self-requested a review August 22, 2023 05:43
Copy link
Member

@bigboss2063 bigboss2063 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigboss2063 bigboss2063 merged commit 40efa02 into nutsdb:master Aug 22, 2023
@bigboss2063
Copy link
Member

感谢你的贡献😁

@G-XD G-XD deleted the refactor_set_test branch August 22, 2023 06:17
TremblingV5 pushed a commit to TremblingV5/nutsdb that referenced this pull request Aug 22, 2023
* [Test] Restart the database using three modes

* [Test] Restart the database using three modes

* fix bug

* fix coverage bug

* gofumpt

* Rebuilding Indexes After Loading All Data

* Changing countFlag to a Const

* Refactoring building index

* remove countflag

fix: fix bug in `txZCard` (nutsdb#444)

test: refactor `tx_set_test` (nutsdb#445)

* test: refactor tx_set_test

* test: refactor TestTx_SKeys

* test: refactor TestTx_SRem2

remove func ErrWhenBuildListIdx

update buildListIdx

update error wrap for buildSortedSetIdx

update

remove func ErrWhenBuildListIdx

update buildListIdx

update error wrap for buildSortedSetIdx

update
TremblingV5 pushed a commit to TremblingV5/nutsdb that referenced this pull request Aug 22, 2023
* [Test] Restart the database using three modes

* [Test] Restart the database using three modes

* fix bug

* fix coverage bug

* gofumpt

* Rebuilding Indexes After Loading All Data

* Changing countFlag to a Const

* Refactoring building index

* remove countflag

fix: fix bug in `txZCard` (nutsdb#444)

test: refactor `tx_set_test` (nutsdb#445)

* test: refactor tx_set_test

* test: refactor TestTx_SKeys

* test: refactor TestTx_SRem2

remove func ErrWhenBuildListIdx

update buildListIdx

update error wrap for buildSortedSetIdx

update

remove func ErrWhenBuildListIdx

update buildListIdx

update error wrap for buildSortedSetIdx

update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants