-
Notifications
You must be signed in to change notification settings - Fork 345
test: refactor tx_set_test
#445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #445 +/- ##
==========================================
- Coverage 66.97% 66.26% -0.71%
==========================================
Files 34 34
Lines 5910 5902 -8
==========================================
- Hits 3958 3911 -47
- Misses 1606 1632 +26
- Partials 346 359 +13 |
Member
|
TestTx_SRem2 中 83-88 是否也用封装好的 txSAreMembers 比较好? |
bigboss2063
approved these changes
Aug 22, 2023
Member
bigboss2063
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Member
|
感谢你的贡献😁 |
TremblingV5
pushed a commit
to TremblingV5/nutsdb
that referenced
this pull request
Aug 22, 2023
* [Test] Restart the database using three modes * [Test] Restart the database using three modes * fix bug * fix coverage bug * gofumpt * Rebuilding Indexes After Loading All Data * Changing countFlag to a Const * Refactoring building index * remove countflag fix: fix bug in `txZCard` (nutsdb#444) test: refactor `tx_set_test` (nutsdb#445) * test: refactor tx_set_test * test: refactor TestTx_SKeys * test: refactor TestTx_SRem2 remove func ErrWhenBuildListIdx update buildListIdx update error wrap for buildSortedSetIdx update remove func ErrWhenBuildListIdx update buildListIdx update error wrap for buildSortedSetIdx update
TremblingV5
pushed a commit
to TremblingV5/nutsdb
that referenced
this pull request
Aug 22, 2023
* [Test] Restart the database using three modes * [Test] Restart the database using three modes * fix bug * fix coverage bug * gofumpt * Rebuilding Indexes After Loading All Data * Changing countFlag to a Const * Refactoring building index * remove countflag fix: fix bug in `txZCard` (nutsdb#444) test: refactor `tx_set_test` (nutsdb#445) * test: refactor tx_set_test * test: refactor TestTx_SKeys * test: refactor TestTx_SRem2 remove func ErrWhenBuildListIdx update buildListIdx update error wrap for buildSortedSetIdx update remove func ErrWhenBuildListIdx update buildListIdx update error wrap for buildSortedSetIdx update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#403