ENH: Rationalize f2py callback check to just require callable#31599
Open
da-woods wants to merge 3 commits into
Open
ENH: Rationalize f2py callback check to just require callable#31599da-woods wants to merge 3 commits into
da-woods wants to merge 3 commits into
Conversation
... rather than specific types of callable. This means that we can eliminate the PyFortranType_Check1 (which is hard to do in the Limited API) because it's just caught by callable. Also get rid of some dead py2 code-paths.
da-woods
commented
Jun 10, 2026
| } | ||
| Py_XDECREF(tmp); | ||
| } | ||
| else if (PyFortran_Check(fun) || PyFortran_Check1(fun)) { |
Contributor
Author
There was a problem hiding this comment.
Really the motivation is just getting rid of this line to avoid adapting PyFortran_Check1 for the Limited API.
It would definitely be possible to adapt the check though for a less intrusive fix. But the cleanup felt like an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
... rather than specific types of callable. This means that we can eliminate the PyFortranType_Check1 (which is hard to do in the Limited API) because it's just caught by callable.
Also:
im_func)AI Disclosure
No AI usage.