ENH: handle masked arrays on histogram.#31491
Open
JosephMehdiyev wants to merge 2 commits into
Open
Conversation
Add logic to handle masked data and masked weights on histogram.
Contributor
Author
|
hmmmm, something is very wrong about CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logic to handle masked data and masked weights on histogram.
fixes #10019
PR summary
This PR makes weights and the input data to be possibly passed with masked arrays.
If both the weights and input are masked, it will combine the masked data as I feel like this is more natural. It will not raise errors if masks are not matched.
Other comments
note that this PR does not add masked support for histogramdd. I will open other PRs for it (hopefully).
AI Disclosure
the lines 297-302 was generated by Claude (because of lazyness)
tests were partially written by claude
Claude was also used to review the code