Skip to content

Updated variant index tag definitions for compatibility with clang #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martinmoene merged 1 commit into from
Sep 28, 2025
Merged

Updated variant index tag definitions for compatibility with clang #56

martinmoene merged 1 commit into from
Sep 28, 2025

Conversation

@geghamyan
Copy link

@geghamyan geghamyan commented Sep 23, 2025 •
edited by martinmoene
Loading

  • Replaced the non-type template parameter with a pointer, which should resolve the reference issue with Clang.
  • Fixed unit tests failing with the latest versions of GCC and Clang [edit MM: with std::variant].

@geghamyan geghamyan mentioned this pull request Sep 23, 2025
Closed
@martinmoene
Copy link
Collaborator

martinmoene commented Sep 24, 2025

Added clang 17 to GitHub Actions and interestingly there it does not fail.

martinmoene added a commit that referenced this pull request Sep 24, 2025
@martinmoene
Add test case for "Undefined reference to index_tag<0ul>" on clang-17…
9c066f5 
… and later (issue #54, pr #56, thanks @geghamyan)
@martinmoene
Copy link
Collaborator

martinmoene commented Sep 24, 2025 •
edited
Loading

Added test case for "Undefined reference to index_tag<0ul>" on clang-17 and later (issue #54 , this PR #56), 9c066f5

This apparently compiles successfully with clang-17.

I'm at a loss what I'm missing...

@geghamyan
Copy link
Author

geghamyan commented Sep 24, 2025

The issue is reproducible with the following flags "-std=c++11 -O0 -g"
In the PR I have added CMAKE_CXX_FLAGS_DEBUG , which can be triggered by passing -DCMAKE_BUILD_TYPE=Debug during CMake configuration

@martinmoene
Copy link
Collaborator

martinmoene commented Sep 24, 2025

@geghamyan Ah, yes, thanks.

@martinmoene martinmoene merged commit 7c5fd38 into nonstd-lite:master Sep 28, 2025
5 of 7 checks passed
martinmoene added a commit that referenced this pull request Sep 28, 2025
@martinmoene
Make cases for different compilers more alike (#56, thanks @geghamyan)
af04264
@martinmoene martinmoene mentioned this pull request Sep 28, 2025
Closed
@geghamyan
Copy link
Author

geghamyan commented Sep 29, 2025

@martinmoene Thank you for integrating the changes. I was wondering, when are you planning the next tag/release?

@martinmoene
Copy link
Collaborator

martinmoene commented Sep 29, 2025

@geghamyan , Thanks for providing the PR.

I'm currently working on issue #48, hope to make a new release in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@geghamyan @martinmoene