Improve error handling in case of HTTP errors

eht16 · eht16 · commit 534145d17892 · 2015-10-21T22:40:34.000+02:00
In case of a HTTP status code 404, the returned 'r' was never assigned.
In case of URL errors which are not timeouts, we probably should bail
out.
diff --git a/bin/github-backup b/bin/github-backup
@@ -304,8 +304,11 @@ def _get_response(request, auth, template):
             r = urllib2.urlopen(request)
         except urllib2.HTTPError as exc:
             errors, should_continue = _request_http_error(exc, auth, errors)  # noqa
+            r = exc
         except urllib2.URLError:
             should_continue = _request_url_error(template, retry_timeout)
+            if not should_continue:
+                raise
 
         if should_continue:
             continue
