fix: Handle FormData body type correctly in RetryAgent retried requests#4692
Merged
mcollina merged 1 commit intonodejs:mainfrom Jan 11, 2026
Merged
fix: Handle FormData body type correctly in RetryAgent retried requests#4692mcollina merged 1 commit intonodejs:mainfrom
mcollina merged 1 commit intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
When a RetryAgent request has FormData body, currently since FormData passes
(body && typeof body !== 'string' && !ArrayBuffer.isView(body) && isIterable(body))it gets converted to BodyAsyncIterable which leads to extractBody() never being called on retried requests. Now FormData body is checked for and returned without manipulation.Changes
Add a new check on the body using the existing isFormDataLike() utility function. Add a new unit test that references the issue number and runs the retry agent with FormData body.
Features
Bug Fixes
Breaking Changes and Deprecations
Status