Skip to content

fix(types): add missing cache prop to RequestInit#3569

Merged
mcollina merged 1 commit intonodejs:mainfrom
rindeal:patch-1
Oct 15, 2024
Merged

fix(types): add missing cache prop to RequestInit#3569
mcollina merged 1 commit intonodejs:mainfrom
rindeal:patch-1

Conversation

@rindeal
Copy link
Contributor

@rindeal rindeal commented Sep 9, 2024 •
edited
Loading

Also sort the props.

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@eXhumer
Copy link
Contributor

eXhumer commented Sep 9, 2024 •
edited
Loading

Lint issues, use 2 spaces instead of 4.

I don't think undici.fetch supports caching yet (See #2760).

If you want to implement some sort of in-memory caching, see #2760 (comment).

@rindeal
Copy link
Contributor Author

rindeal commented Sep 9, 2024

Lint issues, use 2 spaces instead of 4.

yeah, will fix

I don't think undici.fetch supports caching yet (See #2760).

If you want to implement some sort of in-memory caching, see #2760 (comment).

The prop is supported and that's all that matters in this case

undici/lib/web/fetch/request.js

Lines 974 to 979 in dca0aa0

{
key: 'cache',
converter: webidl.converters.DOMString,
// https://fetch.spec.whatwg.org/#requestcache
allowedValues: requestCache
},

@mcollina mcollina requested a review from KhafraDev September 9, 2024 07:29
mcollina
mcollina requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some type tests for this? We use tsd.

Uzlopak
Uzlopak requested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tomorrow somebody argues, that because the cache field is in the types, we need to implement asap caching.

@rindeal
Copy link
Contributor Author

rindeal commented Sep 9, 2024

Can you add some type tests for this? We use tsd.

✅

Uzlopak
Uzlopak approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhafraDev

image

@rindeal
Copy link
Contributor Author

rindeal commented Sep 16, 2024

bump @mcollina

mcollina
mcollina approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 770b2db into nodejs:main Oct 15, 2024
@rindeal rindeal deleted the patch-1 branch October 16, 2024 06:37
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
@renovate renovate bot mentioned this pull request Jan 9, 2025
Open
1 task
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Closed
@github-actions github-actions bot mentioned this pull request May 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rindeal @eXhumer @mcollina @Uzlopak @KhafraDev