Merged
Conversation
Uzlopak
reviewed
Aug 31, 2024
Comment on lines
+124
to
+133
| name = webidl.converters.USVString(name) | ||
|
|
||
| if (arguments.length === 3 || value instanceof Blob) { | ||
| value = webidl.converters.Blob(value, prefix, 'value') | ||
|
|
||
| if (filename !== undefined) { | ||
| filename = webidl.converters.USVString(filename) | ||
| } | ||
| } else { | ||
| value = webidl.converters.USVString(value) |
Member
Author
There was a problem hiding this comment.
No. The webidl stuff occurs before the steps, but the step is also not needed because js doesn't have method overrides (hence the weird webidl here).
The set(name, value) and set(name, blobValue, filename) method steps are:
The first step is telling us to set value to "blobValue" if there were 3 arguments passed, otherwise do nothing. "value" is only ever "value" here.
Uzlopak
approved these changes
Sep 1, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v6.x v6.x
# Navigate to the new working tree
cd .worktrees/backport-v6.x
# Create a new branch
git switch --create backport-3529-to-v6.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e0714063deb24f4887b00e0b90060ac71190b273
# Push it to GitHub
git push --set-upstream origin backport-3529-to-v6.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v6.xThen, create a pull request where the |
Contributor
|
@KhafraDev |
Merged
Closed
Closed
|
Is there a plan to backport this into Node.js v22 LTS? It's still not present in v6.12.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I painfully found out that the wpts are not extensive