CI: https://ci.nodejs.org/job/node-test-commit-node-v8/546/

Need to fix cross-compilation:

19:41:52 python ./configure --verbose  --dest-cpu=arm
19:41:55 gyp: Dependency '/home/iojs/build/workspace/node-cross-compile/tools/v8_gypfiles/v8.gyp:cppgc_base#host' not found while trying to load target /home/iojs/build/workspace/node-cross-compile/tools/v8_gypfiles/v8.gyp:v8_base_without_compiler#host

And macOS:

19:41:43 running: 
19:41:43     python tools/gyp_node.py --no-parallel -Dconfiguring_node=1 -f make-mac
19:41:43 static library v8_base_without_compiler has several files with the same basename:
19:41:43   allocation: ../../deps/v8/src/utils/allocation.cc ../../deps/v8/src/heap/cppgc/allocation.cc
19:41:43   free-list: ../../deps/v8/src/heap/free-list.cc ../../deps/v8/src/heap/cppgc/free-list.cc
19:41:43   sweeper: ../../deps/v8/src/heap/sweeper.cc ../../deps/v8/src/heap/cppgc/sweeper.cc
19:41:43   heap: ../../deps/v8/src/heap/heap.cc ../../deps/v8/src/heap/cppgc/heap.cc
19:41:43 libtool on OS X will generate warnings for them.
19:41:43 Error running GYP
19:41:43 make: *** [build-ci] Error 1

And Windows:

19:46:05   cpp-heap.cc
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\xutility(3778,16): error C2280: 'std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>::operator =(const std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &)': attempting to reference a deleted function [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\memory(1917): message : see declaration of 'std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>::operator =' [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\memory(1917,17): message : 'std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>::operator =(const std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>> &)': function was explicitly deleted [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
19:46:05 C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.26.28801\include\vector(1127): message : see reference to function template instantiation '_OutIt *std::_Copy_unchecked<_Iter,std::unique_ptr<cppgc::internal::BaseSpace,std::default_delete<cppgc::internal::BaseSpace>>*>(_InIt,_InIt,_OutIt)' being compiled [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

/cc @nodejs/v8

Uh oh!

Port cppgc config to gyp #161

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions