No abort on require() with null bytes#8277
Closed
rvagg wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InternalModuleReadFile()returningUndefinedso we don't get anabort()whenuv_fs_read()raises an error (currently it's only on\u0000that I can find an error but perhaps there are others).nullBytes()check inreadPackage()so we get a proper error rather than a truncated one. This is also consistent with the behaviour ofrequire()on null bytes prior to the introduction of the fast-path reads that now exist in v4.x+.This comes from 1bbf8d0 which is in v4.x and v6.x. In v0.12 and prior you'd get a normal "null bytes not allowed" error thrown when using a
require()involving\u0000.