Skip to content

deps: disable rust icu compiled_data features#62284

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:temporal_icu
Mar 18, 2026
Merged

deps: disable rust icu compiled_data features#62284
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:temporal_icu

Conversation

@legendecas
Copy link
Copy Markdown
Member

Disable icu_calendar and icu_locale default features so compiled_data
features are not enabled by default. The compiled_data feature might be
enabled indirectly, but it could be removed when upgrading temporal_rs.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 16, 2026
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 17, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 18, 2026
@nodejs-github-bot nodejs-github-bot merged commit 56aba88 into nodejs:main Mar 18, 2026
82 of 83 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 56aba88

@legendecas legendecas deleted the temporal_icu branch March 18, 2026 20:34
aduh95 pushed a commit that referenced this pull request Mar 25, 2026
PR-URL: #62284
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
VaishnavIUpadyaya pushed a commit to VaishnavIUpadyaya/node that referenced this pull request Mar 27, 2026
PR-URL: nodejs#62284
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
aduh95 pushed a commit that referenced this pull request Mar 28, 2026
PR-URL: #62284
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
aduh95 pushed a commit to Flarna/node that referenced this pull request Mar 30, 2026
PR-URL: nodejs#62284
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants